[No QA] Make createNewVersion callable by anyone with write access#9879
Conversation
| steps: | ||
| - name: Get user permissions | ||
| id: getUserPermissions | ||
| run: echo "::set-output name=PERMISSION::$(gh api /repos/Expensify/App/collaborators/roryabraham/permission | jq -r '.permission')" |
There was a problem hiding this comment.
Can you explain this line and why it is hardcoding your user?
There was a problem hiding this comment.
WHHOOOOPS good catch
There was a problem hiding this comment.
And all it's doing is querying this API endpoint and then outputting the permission field of the response.
I found in my testing that I had to use a PAT instead of the regular GitHub token, which was surprising because it's just a READ endpoint. I think it must be because it's using gh api and it's not validating the actual endpoint used?
roryabraham
changed the title
|
Updated to use |
|
🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀
|
4 participants
Details
The
createNewVersionworkflow was not being called when the actor was not OSBotify. We need it to able to = be called by anyone with write access to the repo.Fixed Issues
$ n/a – broken deploys
Tests
Public-Test-Repo: https://github.com/Andrew-Test-Org/Public-Test-Repo/actions/runs/2665173073