Remove extra line under codeblock#435
Merged
nkuoch merged 1 commit intoFeb 10, 2022
Merged
Conversation
Contributor
Author
|
Found this issue while working on this PR https://expensify.slack.com/archives/C01GTK53T8Q/p1644507497800049 |
nkuoch
approved these changes
Feb 10, 2022
6 tasks
Member
|
This change will be deployed to Expensify/App in the above PR (7700) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Beamanator @rushatgabhane will you please review this?
Code block is wrapped by
<pre></pre>tags. And When new line is added<br />tag is also added. So, In turn,</pre> <br />tags get added in the html.Here,
</pre>tag changes the line and<br />add another line. So there is extra line.Fixed Issues
$ Expensify/App#7496
Tests
Send some code blocks in chat like
Here is come code
And that was my code!
There should not be an extra line below the codeblock.
QA
Send some code blocks in chat like
Here is come code
And that was my code!
There should not be an extra line below the codeblock.
Screenshots
Web
Desktop
Android
IOS
mWeb