Skip to content

fix: replace removed ShadowNode::Shared with std::shared_ptr<const ShadowNode>#756

Merged
tomekzaw merged 1 commit into
mainfrom
@tomekzaw/remove-shared-node-shared
May 26, 2026
Merged

fix: replace removed ShadowNode::Shared with std::shared_ptr<const ShadowNode>#756
tomekzaw merged 1 commit into
mainfrom
@tomekzaw/remove-shared-node-shared

Conversation

@tomekzaw
Copy link
Copy Markdown
Collaborator

Details

Upstream React Native removed the ShadowNode::Shared type alias, which broke the iOS Fabric build on Expo SDK 56+ / RN nightly with errors like no type named 'Shared' in 'facebook::react::ShadowNode'. This replaces the four usages of ShadowNode::Shared in MarkdownTextInputDecoratorShadowNode (.h and .mm) with std::shared_ptr<const ShadowNode>, matching the current YogaLayoutableShadowNode::appendChild / replaceChild override signatures.

Other ::Shared usages in the project (ShadowNodeFamily::Shared, Props::Shared) are still defined upstream and remain unchanged.

Related Issues

Closes #755

Manual Tests

  • Build the example app on iOS with the New Architecture enabled against an RN version that removed ShadowNode::Shared (Expo SDK 56 / RN nightly).
  • Build the example app on iOS against the currently-pinned RN 0.83.1 to confirm no regression on the older signature.

Linked PRs

N/A

… ShadowNode>`

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@tomekzaw tomekzaw merged commit c6df3dc into main May 26, 2026
7 of 14 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/remove-shared-node-shared branch May 26, 2026 13:31
@os-botify
Copy link
Copy Markdown
Contributor

os-botify Bot commented May 26, 2026

🚀 Published to npm in 0.1.326 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Error on Expo ~56.0.4 + live-markdown ^0.1.325 (New Arch): "no type named 'Shared' in 'facebook::react::ShadowNode'"

2 participants