Skip to content

fix: replace removed ShadowNode::Shared with std::shared_ptr<const ShadowNode> #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomekzaw merged 1 commit into from
May 26, 2026
+4 −4
Merged

fix: replace removed ShadowNode::Shared with std::shared_ptr<const ShadowNode> #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apple/MarkdownTextInputDecoratorShadowNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ class JSI_EXPORT MarkdownTextInputDecoratorShadowNode final
MarkdownTextInputDecoratorShadowNode(ShadowNode const &sourceShadowNode,
ShadowNodeFragment const &fragment);

void appendChild(const ShadowNode::Shared &child) override;
void appendChild(const std::shared_ptr<const ShadowNode> &child) override;
void replaceChild(const ShadowNode &oldChild,
const ShadowNode::Shared &newChild,
const std::shared_ptr<const ShadowNode> &newChild,
size_t suggestedIndex = SIZE_MAX) override;
void layout(LayoutContext layoutContext) override;
Size
Expand Down
4 changes: 2 additions & 2 deletions apple/MarkdownTextInputDecoratorShadowNode.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,14 @@
}

void MarkdownTextInputDecoratorShadowNode::appendChild(
const ShadowNode::Shared &child) {
const std::shared_ptr<const ShadowNode> &child) {
YogaLayoutableShadowNode::appendChild(child);

overwriteMeasureCallbackConnector();
}

void MarkdownTextInputDecoratorShadowNode::replaceChild(
const ShadowNode &oldChild, const ShadowNode::Shared &newChild,
const ShadowNode &oldChild, const std::shared_ptr<const ShadowNode> &newChild,
size_t suggestedIndex) {
YogaLayoutableShadowNode::replaceChild(oldChild, newChild, suggestedIndex);

Expand Down
Loading