Add initial code and dependencies#1
Conversation
marcaaron
left a comment
marcaaron
left a comment
There was a problem hiding this comment.
Couple thoughts...
- The source looks like it needs to be updated
- There was a conversation about changing the name of
IontoOnyxso maybe it would be a good time to make that change - Can we build this with webpack and publish a distribution so it is easier to utilize by anyone? Should be pretty easy to do so I think https://webpack.js.org/guides/author-libraries/
- I'd expect that we'd also have
withIonexisting in this library and not onlyIonso we can do things like
import Ion, {withIon} from 'react-ion';|
|
||
| - Ion stores and retrieves data from persistent storage | ||
| - Data is stored as key/value pairs, where the value can be anything from a single piece of data to a complex object | ||
| - Collections of data are usually not stored as a single key (eg. an array with multiple objects), but as individual keys+ID (eg. `report_1234`, `report_4567`, etc.). Store collections as individual keys when a component will bind directly to one of those keys. For example: reports are stored as individual keys because `SidebarLink.js` binds to the individual report keys for each link. However, report actions are stored as an array of objects because nothing binds directly to a single report action. |
There was a problem hiding this comment.
Maybe not needed right now, but we might want to be more neutral with our examples if this is getting open sourced.
| # EditorConfig is awesome: http://EditorConfig.org | ||
|
|
||
| # Howto with your editor: | ||
| # Sublime: https://github.com/sindresorhus/editorconfig-sublime |
There was a problem hiding this comment.
Could add VSCode here ?
|
Adding I'll look into renaming Onyx, and I'll probably remove the sublime stuff completely just because I don't want to maintain a list of every editor and how to use .editorconfig (it's easy to google). |
|
Sounds like I am going to go ahead and rename it, yep. I'll have someone change the name of the repo. And since I'm renaming it, I'm also going to add and rename |
tgolen
changed the title
|
Merge commit for JS-Libs here: Expensify/expensify-common@92b874e |
marcaaron
left a comment
marcaaron
left a comment
There was a problem hiding this comment.
LGTM! Thanks for doing this!!!
Just needs that JS-Libs version bump and we are good to go here.
One thing to follow up on (I'd be up for looking into this)...
eslint caught a couple errors so maybe we can add a GH action to run lint
| "author": "Expensify, Inc.", | ||
| "homepage": "https://expensify.com", | ||
| "description": "State management for React Native", | ||
| "private": true, |
There was a problem hiding this comment.
Probably will want to remove this when we publish. I think this flag just prevents publishing.
There was a problem hiding this comment.
Yeah, I figured we would leave this for now.
marcaaron
changed the title
2 participants
Held on https://github.com/Expensify/Expensify/issues/145764 while the repo is renamed.
This adds the initial Ion library.
Tests
This will be tested as part of Expensify/App#784