WIP: Increase runs/warmupRuns for flaky Reassure perf tests#744
Closed
abzokhattab wants to merge 1 commit into
Closed
WIP: Increase runs/warmupRuns for flaky Reassure perf tests#744abzokhattab wants to merge 1 commit into
abzokhattab wants to merge 1 commit into
Conversation
…) bug
Add runs: 30 and warmupRuns: 3 to the top flaky perf tests
(keyChanged, fireCallbacks, scheduleSubscriberUpdate,
doAllCollectionItemsBelongToSameParent, isValidNonEmptyCollectionForMerge)
to reduce CI noise through statistical averaging.
Also fix Boolean('false') evaluating to true in validateReassureOutput,
which caused the delta check to print the wrong error message.
abzokhattab
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #741. $ Expensify/App#80320
The previous PR raised stability check thresholds from 10ms/20% to 20ms/40%, which helped but wasn't sufficient on its own. The delta check (base vs PR-head, 10ms/20%) is also affected by CI noise, and we don't want to loosen those thresholds since they catch real regressions.
This PR takes a different approach — increasing the number of measurement samples for the most flaky tests to reduce variance through statistical averaging:
Tests updated with
runs: 30, warmupRuns: 3(default isruns: 10, warmupRuns: 1):keyChanged— Add initial code and dependencies #1 most flaky test (33 failures in analysis)fireCallbacks— Update IONKEYS to ONYXKEYS in Readme #2 most flaky test (20 failures)scheduleSubscriberUpdate— (7 failures)doAllCollectionItemsBelongToSameParent— low baseline (~1.2ms), extreme relative deviationsisValidNonEmptyCollectionForMerge— low baseline, extreme relative deviationsThis improves signal quality for both the stability check and the delta check without loosening any thresholds.
Bonus fix:
Boolean('false')evaluates totruein JS (non-empty string), causing the delta check to print the wrong error message ("during stability checks" instead of the correct message). Fixed by using=== 'true'comparison.Test plan