Skip to content

New models#194

Merged
bsb808 merged 5 commits into
masterfrom
feature/bsb/newmodels
Feb 19, 2022
Merged

New models#194
bsb808 merged 5 commits into
masterfrom
feature/bsb/newmodels

Conversation

@bsb808
Copy link
Copy Markdown
Contributor

@bsb808 bsb808 commented Feb 11, 2022

This PR adds three new object models (torpedo, flight-data-recorder, sonobuoy and three unexploded ordnance) along with a demonstration world.

Reviewer should be able to run the command

roslaunch dave_demo_launch dave_models.launch 

and view a minimal world with the three now models on the seafloor:

Screenshot from 2022-02-11 16-34-37

Please check that the link coordinate frames make sense and that the collision meshes are appropriate. I find it easiest to use the Gazebo gui to view this attributes.

Copy link
Copy Markdown
Contributor

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone else who knows what's "correct" should review this. I just took a brief look to steal the SDF file to test other models.

Coordinate frames look right - assuming all of them being Z up X forward is what we want.
2022-02-12-035143_3706x2049_scrot

Inertia boxes look off. Do we care about that? If we are planning to use them for manipulation, that might not be negligible.
2022-02-12-035234_3706x2049_scrot

Side note, I see the light/dark shadow upstream bug now... Guess I have the dark version.

Also saw another upstream bug that if I enable skeleton view, then disable it, then enable inertia view, all the magenta boxes are opaque as opposed to translucent. Probably not an urgent thing to fix. FYI @WilliamLewww

@bsb808
Copy link
Copy Markdown
Contributor Author

bsb808 commented Feb 19, 2022

@mabelzhang Good catch on the inertia values. I improved them. Still coarse estimates, but I think they should be sufficient for dave.
Screenshot from 2022-02-18 17-52-32

@bsb808 bsb808 mentioned this pull request Feb 19, 2022
@mabelzhang
Copy link
Copy Markdown
Contributor

Looks good. Did you intentionally skip torpedo_mk46 for the inertials? Wanted to double-check before approving.

Copy link
Copy Markdown
Contributor

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh never mind, that one was already correct.

Thanks for adding them!

@bsb808 bsb808 merged commit 3a1dcf9 into master Feb 19, 2022
@bsb808 bsb808 deleted the feature/bsb/newmodels branch February 19, 2022 21:52
This was referenced Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants