Skip to content

fix(example): ENDORSEMENTS_ADDRESS identifier#572

Merged
wjmelements merged 1 commit into
masterfrom
fix-568-identifier
Jan 27, 2026
Merged

fix(example): ENDORSEMENTS_ADDRESS identifier#572
wjmelements merged 1 commit into
masterfrom
fix-568-identifier

Conversation

@wjmelements
Copy link
Copy Markdown
Contributor

Reviewer @rvagg
This bug was introduced in #568

Changes

  • fix identifier

@wjmelements
Copy link
Copy Markdown
Contributor Author

I have tested this locally. The script works with a custom ENDORSEMENT_ADDRESS.

Endorsements Address: 0x2326BaC9Fc8eA9617B130689b3B149b443A10d43

@wjmelements wjmelements merged commit 3bc6a7f into master Jan 27, 2026
4 checks passed
@wjmelements wjmelements deleted the fix-568-identifier branch January 27, 2026 02:44
@github-project-automation github-project-automation Bot moved this from 📌 Triage to 🎉 Done in FOC Jan 27, 2026
wjmelements added a commit to wjmelements/foc-devnet that referenced this pull request Jan 27, 2026
redpanda-f pushed a commit to FilOzone/foc-devnet that referenced this pull request Jan 27, 2026
* load endorsments address from contract_addresses.json into env

* update filecoin-services and synapse-sdk

* cargo fmt --all

* pull FilOzone/filecoin-services#400

* pull FilOzone/synapse-sdk#572
bajtos added a commit that referenced this pull request Jan 27, 2026
* feat: add github link to filecoin cloud (#525)

* refactor: move FilBeam domain to chain configuration

Replace hardcoded chainId check in createPieceUrl with chain configuration lookup. Add filbeam.retrievalDomainName to Chain interface and configure it for mainnet, calibration, and devnet.

Co-Authored-By: Claude Code <noreply@anthropic.com>

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>

* feat(example): Devnet Endorsements (#568)

add ENDORSEMENTS_ADDRESS env config to utils/example-storage-e2e.js

* fix(example): ENDORSEMENTS_ADDRESS identifier (#572)

chore: fix identifier

* refactor: rename retrievalDomainName to retrievalDomain

---------

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Co-authored-by: Abhivansh <31AbhivanshJ@gmail.com>
Co-authored-by: William Morriss <wjmelements@gmail.com>
hugomrdias pushed a commit that referenced this pull request Feb 2, 2026
* feat: add github link to filecoin cloud (#525)

* refactor: move FilBeam domain to chain configuration

Replace hardcoded chainId check in createPieceUrl with chain configuration lookup. Add filbeam.retrievalDomainName to Chain interface and configure it for mainnet, calibration, and devnet.

Co-Authored-By: Claude Code <noreply@anthropic.com>

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>

* feat(example): Devnet Endorsements (#568)

add ENDORSEMENTS_ADDRESS env config to utils/example-storage-e2e.js

* fix(example): ENDORSEMENTS_ADDRESS identifier (#572)

chore: fix identifier

* refactor: rename retrievalDomainName to retrievalDomain

---------

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Co-authored-by: Abhivansh <31AbhivanshJ@gmail.com>
Co-authored-by: William Morriss <wjmelements@gmail.com>
hugomrdias pushed a commit that referenced this pull request Feb 3, 2026
* feat: add github link to filecoin cloud (#525)

* refactor: move FilBeam domain to chain configuration

Replace hardcoded chainId check in createPieceUrl with chain configuration lookup. Add filbeam.retrievalDomainName to Chain interface and configure it for mainnet, calibration, and devnet.

Co-Authored-By: Claude Code <noreply@anthropic.com>

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>

* feat(example): Devnet Endorsements (#568)

add ENDORSEMENTS_ADDRESS env config to utils/example-storage-e2e.js

* fix(example): ENDORSEMENTS_ADDRESS identifier (#572)

chore: fix identifier

* refactor: rename retrievalDomainName to retrievalDomain

---------

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Co-authored-by: Abhivansh <31AbhivanshJ@gmail.com>
Co-authored-by: William Morriss <wjmelements@gmail.com>
lordshashank pushed a commit to lordshashank/synapse-sdk that referenced this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

2 participants