Skip to content

refactor: move FilBeam domain to chain configuration#570

Merged
bajtos merged 7 commits into
hugomrdias/paymentsfrom
filbeam-chain-config
Jan 27, 2026
Merged

refactor: move FilBeam domain to chain configuration#570
bajtos merged 7 commits into
hugomrdias/paymentsfrom
filbeam-chain-config

Conversation

@bajtos
Copy link
Copy Markdown
Collaborator

@bajtos bajtos commented Jan 26, 2026

Summary

  • Add filbeam.retrievalDomainName property to the Chain interface
  • Configure FilBeam domains for mainnet (filbeam.io), calibration (calibration.filbeam.io), and devnet (localhost:8080)
  • Update createPieceUrl to use chain configuration instead of hardcoded chainId check
  • Update all callers to pass Chain instead of chainId

Test plan

  • All 351 existing tests pass
  • New tests for createPieceUrl covering all three chains
  • Build passes
  • Linter passes

@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Jan 26, 2026
@bajtos
refactor: move FilBeam domain to chain configuration
39f49e0 
Replace hardcoded chainId check in createPieceUrl with chain configuration lookup. Add filbeam.retrievalDomainName to Chain interface and configure it for mainnet, calibration, and devnet.

Co-Authored-By: Claude Code <noreply@anthropic.com>

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos force-pushed the filbeam-chain-config branch from b95801b to 39f49e0 Compare January 26, 2026 14:13
@bajtos bajtos moved this from 📌 Triage to 🔎 Awaiting review in FOC Jan 26, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jan 26, 2026 •
edited
Loading

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs		 synapse-dev 0551853 Jan 27 2026, 01:11 PM

bajtos
bajtos commented Jan 26, 2026
View reviewed changes
Comment thread packages/synapse-core/src/utils/piece-url.ts
@wjmelements
feat(example): Devnet Endorsements (#568)
64c1601 
add ENDORSEMENTS_ADDRESS env config to utils/example-storage-e2e.js
@wjmelements
fix(example): ENDORSEMENTS_ADDRESS identifier (#572)
3bc6a7f 
chore: fix identifier
@rvagg
Copy link
Copy Markdown
Collaborator

rvagg commented Jan 27, 2026

seems good to me, although I hope that devnet address isn't important for the standard path because so many things want to listen to 8080 there's a good chance you'll hit something existing on dev machines

@bajtos
Copy link
Copy Markdown
Collaborator Author

bajtos commented Jan 27, 2026

seems good to me, although I hope that devnet address isn't important for the standard path because so many things want to listen to 8080 there's a good chance you'll hit something existing on dev machines

Yeah, I share your concern.

Actually, FilBeam does not support local devnet. It would be nice to throw a helpful error when trying to retrieve a devnet piece via FilBeam, but it's not clear to me how to achieve that and I feel this is not worth our effort right now.

@rvagg
Copy link
Copy Markdown
Collaborator

rvagg commented Jan 27, 2026

there is the filbeam retriever in synapse-sdk, maybe it should be pulling the base address from the chain? in that case, a better port number might be advisable because I think we include it in the default retrieval path

@bajtos
Copy link
Copy Markdown
Collaborator Author

bajtos commented Jan 27, 2026

How do you feel about using filbeam.localhost:8080 for devnet? It won't work out of the box, but it's possible to configure your machine to make that hostname work, plus the hostname is IMO descriptive enough to make it clear what's going on when somebody tries FilBeam retrievals for devnet pieces.

hugomrdias
hugomrdias approved these changes Jan 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@hugomrdias hugomrdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a suggestion for the prop name

Comment thread packages/synapse-core/src/chains.ts Outdated
}
}
filbeam: {
retrievalDomainName: string
Copy link
Copy Markdown
Member

@hugomrdias hugomrdias Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
retrievalDomainName: string
retrievalDomain: string

Copy link
Copy Markdown
Collaborator Author

@bajtos bajtos Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed in daa9035

@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC Jan 27, 2026
@bajtos bajtos merged commit 3f9f831 into hugomrdias/payments Jan 27, 2026
2 of 3 checks passed
@bajtos bajtos deleted the filbeam-chain-config branch January 27, 2026 13:09
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Jan 27, 2026
@bajtos bajtos mentioned this pull request Jan 27, 2026
Merged
@bajtos
Copy link
Copy Markdown
Collaborator Author

bajtos commented Jan 27, 2026

there is the filbeam retriever in synapse-sdk, maybe it should be pulling the base address from the chain? in that case, a better port number might be advisable because I think we include it in the default retrieval path

I will follow-up with another PR

@bajtos bajtos mentioned this pull request Jan 27, 2026
Merged
@bajtos
Copy link
Copy Markdown
Collaborator Author

bajtos commented Jan 27, 2026

The follow-up PR:

hugomrdias pushed a commit that referenced this pull request Feb 2, 2026
@bajtos @akronim26
@wjmelements @hugomrdias
refactor: move FilBeam domain to chain configuration (#570)
6578c8d 
* feat: add github link to filecoin cloud (#525)

* refactor: move FilBeam domain to chain configuration

Replace hardcoded chainId check in createPieceUrl with chain configuration lookup. Add filbeam.retrievalDomainName to Chain interface and configure it for mainnet, calibration, and devnet.

Co-Authored-By: Claude Code <noreply@anthropic.com>

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>

* feat(example): Devnet Endorsements (#568)

add ENDORSEMENTS_ADDRESS env config to utils/example-storage-e2e.js

* fix(example): ENDORSEMENTS_ADDRESS identifier (#572)

chore: fix identifier

* refactor: rename retrievalDomainName to retrievalDomain

---------

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Co-authored-by: Abhivansh <31AbhivanshJ@gmail.com>
Co-authored-by: William Morriss <wjmelements@gmail.com>
hugomrdias pushed a commit that referenced this pull request Feb 3, 2026
@bajtos @akronim26
@wjmelements @hugomrdias
refactor: move FilBeam domain to chain configuration (#570)
a2a3e95 
* feat: add github link to filecoin cloud (#525)

* refactor: move FilBeam domain to chain configuration

Replace hardcoded chainId check in createPieceUrl with chain configuration lookup. Add filbeam.retrievalDomainName to Chain interface and configure it for mainnet, calibration, and devnet.

Co-Authored-By: Claude Code <noreply@anthropic.com>

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>

* feat(example): Devnet Endorsements (#568)

add ENDORSEMENTS_ADDRESS env config to utils/example-storage-e2e.js

* fix(example): ENDORSEMENTS_ADDRESS identifier (#572)

chore: fix identifier

* refactor: rename retrievalDomainName to retrievalDomain

---------

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Co-authored-by: Abhivansh <31AbhivanshJ@gmail.com>
Co-authored-by: William Morriss <wjmelements@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugomrdias hugomrdias hugomrdias approved these changes

@rvagg rvagg Awaiting requested review from rvagg

Assignees

No one assigned

Labels

None yet

Projects

FOC
Status: 🎉 Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bajtos @rvagg @hugomrdias @akronim26 @wjmelements