refactor: use Chain type for FilBeam retriever config#573
Conversation
Replace FilecoinNetworkType with Chain from synapse-core in FilBeamRetriever, reading the retrieval domain from chain configuration instead of hardcoding network-to-domain mapping. Co-Authored-By: Claude Code <noreply@anthropic.com> Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | 6cf8b3e | Commit Preview URL Branch Preview URL |
Jan 28 2026, 04:36 PM |
|
@rvagg re: #570 (comment)
Would you like me to change the devnet FilBeam domain in this PR? What value do you suggest? |
|
Re-posting another relevant comment:
|
|
There is one more caveat that I realised just now: We are always using HTTPS protocol for FilBeam retrievals. That's fine for mainnet and calibration testnet, but probably too difficult to set up for local devnet 🤔 |
|
And here's my concern about port 8080, we always wrap the FilBeam retriever an attempt it on local retrievals: |
Yes, I think that's the best option! I'll also log a warning when we fall back to direct retrievals. |
Set chain.filbeam to null for devnet and update all code that accesses it to gracefully handle the missing config. When CDN retrieval is requested but not available, log a warning with chain ID and name, then fall back to direct retrieval via the storage provider. Co-Authored-By: Claude Code <noreply@anthropic.com> Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Co-Authored-By: Claude Code <noreply@anthropic.com> Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
|
In 7d1438a, I reworked This PR is ready for final review and merging as far as I am concerned.
@rvagg @hugomrdias LGTY now? |
rvagg
left a comment
There was a problem hiding this comment.
lgtm, up to Hugo how it lands though cause it's on to his branch
Replace FilecoinNetworkType with Chain from synapse-core in FilBeamRetriever, reading the retrieval domain from chain configuration instead of hardcoding network-to-domain mapping.
Refs: