feat: add locales description command for ios and android by adamfilipow92 · Pull Request #969 · Flank/flank

adamfilipow92 · 2020-08-10T12:44:58Z

Fixes #966

Test Plan

How do we know the code works?

When run


     flank firebase test android|ios locales describe LOCALE_ID

flank should return output like gcloud cli when execute


gcloud alpha firebase test android|ios locales describe LOCALE_ID

example for flank firebase test android locales describe en


id: en
name: English
tags:
- default

example for flank firebase test android locales describe pl


id: pl
name: Polish

example for the wrong LOCALE_ID flank firebase test android locales describe test


ERROR: 'test' is not a valid locale

Checklist

Unit tested
release_notes.md updated

codecov-commenter · 2020-08-11T11:03:57Z

Codecov Report

Merging #969 into master will increase coverage by 0.34%.
The diff coverage is 88.46%.

@@             Coverage Diff              @@
##             master     #969      +/-   ##
============================================
+ Coverage     81.28%   81.62%   +0.34%     
- Complexity      673      687      +14     
============================================
  Files           206      211       +5     
  Lines          3746     3816      +70     
  Branches        569      581      +12     
============================================
+ Hits           3045     3115      +70     
  Misses          395      395              
  Partials        306      306

piotradamczyk5 · 2020-08-12T07:12:06Z

 - [#970](https://github.com/Flank/flank/pull/970) Fixing Flood of snapshot  releases. ([piotradamczyk5](https://github.com/piotradamczyk5))
 - [#972](https://github.com/Flank/flank/pull/972) Fix printing release version. ([piotradamczyk5](https://github.com/piotradamczyk5))
 - [#964](https://github.com/Flank/flank/pull/964) Implement network-profiles describe feature. ([pawelpasterz](https://github.com/pawelpasterz))
+-


not needed :)

Removed thanks :)

piotradamczyk5 · 2020-08-12T07:16:16Z

+    locale.tags.filterNotNull().forEach { tag -> appendln("- $tag") }
+}.toString().trim()
+
+private fun String?.orErrorMessage(locale: String) = this ?: "ERROR: '$locale' is not a valid locale".trimIndent()


I think that trimIndent() is not needed for this simple string message

Thanks! Changed

pawelpasterz

For flank firebase test android locales describe zu_ZA flank is missing region information

pawelpasterz · 2020-08-12T08:08:20Z

+
+    fun getLocaleDescription(projectId: String, locale: String) = getLocales(projectId).getLocaleDescription(locale)
+
+    private fun getLocales(projectId: String) = deviceCatalog(projectId).runtimeConfiguration.locales


I am wondering why do we need projectId to make this request? I mean, I can see from the code that we use it to set a property for request under the hood, but why since it is publicly available information... maybe it's due to 'default' tag...I don't know and just thinking :)

Probably device catalogue could be different for different project ids, so API needs this to return catalogue which is available for current projectID.

@pawelpasterz requested change done. Thanks for the tests. I check if projectID is really required and get feedback
Edit:
We can use empty projectID and result for ios/android is the same but here we loading projectID from selected config or from the default so I think it's ok. I think every flank users have a test-lab project.

WDYT? @pawelpasterz @piotradamczyk5

As per documenation:

`--project` and its fallback` core/project` property play two roles in the invocation. It specifies the project of the resource to operate on.

It has a fallback option, so if the project is not specified in the environmental variable and not provided by config for me it is ok to use empty

hey, we need projectId

the reason is select projects have access to secret device catalogs 🙂 These catalogs are not available to the public.

Probably device catalogue could be different for different project ids,

this is correct!

Let's add a comment that explains why projectId is sent to the device catalog

pawelpasterz

I know I am super annoying but let's also handle those ugly % chars at the end of line

I don't know if this is only me but gcloud does not print them

adamfilipow92 · 2020-08-12T16:14:44Z

I know I am super annoying but let's also handle those ugly % chars at the end of line

I don't know if this is only me but gcloud does not print them

Hmm, I don't see this when I testing. You have right it's should be fixed thanks! I check and fix it.

pawelpasterz

For incorrect locale, gcloud ends run with exit code 1 where flank's s 0. I think we should also reflect this.

adamfilipow92 · 2020-08-13T09:34:37Z

For incorrect locale, gcloud ends run with exit code 1 where flank's s 0. I think we should also reflect this.

Thanks, changed 👍

jan-goral assigned jan-goral and adamfilipow92 and unassigned jan-goral Aug 11, 2020

adamfilipow92 force-pushed the add-locales-describe-command branch from 769975d to 27a10ab Compare August 11, 2020 13:06

adamfilipow92 marked this pull request as ready for review August 11, 2020 13:37

adamfilipow92 requested review from Sloox, bootstraponline, jan-goral, pawelpasterz and piotradamczyk5 August 11, 2020 13:40

piotradamczyk5 reviewed Aug 12, 2020

View reviewed changes

pawelpasterz suggested changes Aug 12, 2020

View reviewed changes

adamfilipow92 requested review from pawelpasterz and piotradamczyk5 August 12, 2020 10:32

piotradamczyk5 previously approved these changes Aug 12, 2020

View reviewed changes

adamfilipow92 changed the title ~~Add locales description command for ios and android~~ feat: add locales description command for ios and android Aug 12, 2020

pawelpasterz reviewed Aug 12, 2020

View reviewed changes

adamfilipow92 dismissed piotradamczyk5’s stale review via b6967a5 August 12, 2020 19:31

pawelpasterz self-requested a review August 13, 2020 06:02

pawelpasterz previously approved these changes Aug 13, 2020

View reviewed changes

pawelpasterz reviewed Aug 13, 2020

View reviewed changes

adamfilipow92 dismissed pawelpasterz’s stale review via b7daa90 August 13, 2020 09:33

adamfilipow92 requested review from pawelpasterz and piotradamczyk5 August 13, 2020 09:34

adamfilipow92 force-pushed the add-locales-describe-command branch from b7daa90 to 56464de Compare August 13, 2020 13:34

pawelpasterz previously approved these changes Aug 13, 2020

View reviewed changes

adamfilipow92 added 15 commits August 14, 2020 09:19

Add locales description for ios and android

cf2bd06

Update LocalesDescription.kt

9903932

Update command parameter description

c9f92d0

Add locale describe tests

afb6222

Update IosLocalesDescribeCommandTest.kt

f9988d9

Update IosLocalesDescribeCommandTest.kt

9c7f8bb

Update release_notes.md

28bedf5

Update tests

8eb9eb8

Update IosLocalesDescribeCommand.kt

68bea7e

code quality

1b37e97

update error description with single quotes

8e67e28

Update LocalesDescription.kt

7f77dc3

Update release_notes.md

3ccbdba

fix % char on the end

c05c6b0

When no locale found exit code: 1

0467c16

adamfilipow92 dismissed pawelpasterz’s stale review via 0467c16 August 14, 2020 07:23

adamfilipow92 force-pushed the add-locales-describe-command branch from 56464de to 0467c16 Compare August 14, 2020 07:23

adamfilipow92 requested a review from pawelpasterz August 14, 2020 07:55

pawelpasterz approved these changes Aug 14, 2020

View reviewed changes

piotradamczyk5 approved these changes Aug 14, 2020

View reviewed changes

adamfilipow92 merged commit e633445 into master Aug 14, 2020

adamfilipow92 deleted the add-locales-describe-command branch August 14, 2020 14:22

bootstraponline mentioned this pull request Aug 19, 2020

chore: release notes for v20.08.2 #1017

Closed

piotradamczyk5 mentioned this pull request Aug 19, 2020

feat: Make release notes more organized #1020

Merged

1 task


		fun getLocaleDescription(projectId: String, locale: String) = getLocales(projectId).getLocaleDescription(locale)

		private fun getLocales(projectId: String) = deviceCatalog(projectId).runtimeConfiguration.locales

Conversation

adamfilipow92 commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Plan

Checklist

Uh oh!

codecov-commenter commented Aug 11, 2020

Codecov Report

Uh oh!

piotradamczyk5 Aug 12, 2020

Choose a reason for hiding this comment

Uh oh!

adamfilipow92 Aug 12, 2020

Choose a reason for hiding this comment

Uh oh!

piotradamczyk5 Aug 12, 2020

Choose a reason for hiding this comment

Uh oh!

adamfilipow92 Aug 12, 2020

Choose a reason for hiding this comment

Uh oh!

pawelpasterz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pawelpasterz Aug 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

piotradamczyk5 Aug 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adamfilipow92 Aug 12, 2020 • edited by pawelpasterz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

piotradamczyk5 Aug 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bootstraponline Aug 12, 2020

Choose a reason for hiding this comment

Uh oh!

bootstraponline Aug 12, 2020

Choose a reason for hiding this comment

Uh oh!

bootstraponline Aug 12, 2020

Choose a reason for hiding this comment

Uh oh!

pawelpasterz left a comment

Choose a reason for hiding this comment

Uh oh!

adamfilipow92 commented Aug 12, 2020 • edited by bootstraponline Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pawelpasterz left a comment

Choose a reason for hiding this comment

Uh oh!

adamfilipow92 commented Aug 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

adamfilipow92 commented Aug 10, 2020 •

edited

Loading

pawelpasterz left a comment •

edited

Loading

pawelpasterz Aug 12, 2020 •

edited

Loading

piotradamczyk5 Aug 12, 2020 •

edited

Loading

adamfilipow92 Aug 12, 2020 •

edited by pawelpasterz

Loading

piotradamczyk5 Aug 12, 2020 •

edited

Loading

adamfilipow92 commented Aug 12, 2020 •

edited by bootstraponline

Loading