Issue/140 by tschob · Pull Request #237 · FolioReader/FolioReaderKit

tschob · 2017-05-09T12:36:07Z

Implements multiple instances support. Solves #140

There is now a third example project which shows two instances in parallel.

Highlight refactor

…rapping

Refactor reader config

kevindelord · 2017-05-23T20:15:13Z

So an internal PR will soon be reviewed and merged. It will fix the remaining issues and bugs.
Could you please try out the app again and found new introduce bugs?

Best!

kevindelord · 2017-05-23T20:18:42Z

Hi again @hebertialmeida,

I'm opening another thread for that small question.
When using horizontalWithVerticalContent, once the user jumps to another chapter (from the chapter list) he is not redirected to the top of the page (with the chapter title) but somewhere else.
This behaviour differs from the vertical and horizontal scroll directions.

I am not sure if this is a bug or feature.
I've also made sure that I have not introduced that problem (if it is one).

Best

…ReaderKit into fork/master

Fix PR comments DBGIOS-1004

hebertialmeida · 2017-05-26T14:24:25Z

So, the horizontalWithVerticalContent should behave like that.

The bar was not showing because now with `setup` function it add multiple times the recognizer to the view, now I remove everything before adding new one

hebertialmeida · 2017-05-26T16:56:55Z

Hey, @tschob and @kevindelord I take a general look at it, improved the animation of tabBar and fixed the bug of not showing it.

The problem was that the gestured is added multiple times to the webView, so when you tap it to toggle the bar the number of times the gestures was added...

Overall it LGTM, so I think we can merge that, take a look at my changes and let me know., then I will merge it.

kevindelord · 2017-05-27T00:29:01Z

@hebertialmeida I don't fully understand why you changed the readerContainer to an optional:

open weak var readerContainer: FolioReaderContainer?

But otherwise it looks good to me. You can merge :)

kevindelord · 2017-05-27T00:33:33Z

-        return self.readerContainer.readerConfig
+    fileprivate var folioReader: FolioReader {
+        guard let readerContainer = readerContainer else { return FolioReader() }
+        return self.readerContainer!.folioReader


like if you had kept the non-optional value this would not have been needed.
Plus you should use the value from the guard instead of the self.readerContainer!.folioReader

Yeah, missed that...

kevindelord · 2017-05-30T14:39:40Z

-
-    /// Called when the application will resign active
-    open class func applicationWillResignActive() {
-        FolioReader.shared.saveReaderState()


Maybe we should keep that for the legacy? I mean when people update the library they could/should get a simple warning.
The function could be empty though, but at least it would still exist :)

As per discussed by Slack, there is no need for this.

kevindelord · 2017-05-30T14:39:57Z

-
-    /// Called when the application will terminate
-    open class func applicationWillTerminate() {
-        FolioReader.shared.saveReaderState()


Same remark here :)

As per discussed by Slack, there is no need for this.

kevindelord · 2017-05-30T14:40:56Z

+    fileprivate func addObservers() {
+        removeObservers()
+        NotificationCenter.default.addObserver(self, selector: #selector(saveReaderState), name: .UIApplicationWillResignActive, object: nil)
+        NotificationCenter.default.addObserver(self, selector: #selector(saveReaderState), name: .UIApplicationWillTerminate, object: nil)


Are you sure this works fine with the multiple instances mode? Like the correct epub gets saved?

It should because each observer is added to self and it is a different object in memory.

hebertialmeida · 2017-05-30T15:21:04Z

-
-    /// Called when the application will resign active
-    open class func applicationWillResignActive() {
-        FolioReader.shared.saveReaderState()


As per discussed by Slack, there is no need for this.

hebertialmeida · 2017-05-30T15:21:12Z

-
-    /// Called when the application will terminate
-    open class func applicationWillTerminate() {
-        FolioReader.shared.saveReaderState()


As per discussed by Slack, there is no need for this.

hebertialmeida · 2017-05-30T15:22:26Z

@kevindelord @tschob Thank you guys, this is a huge improvement!!

kevindelord added 30 commits March 28, 2017 17:34

Storyboard example now full screen. Update podfile

14bec27

Update gitignore

1b8f389

Add TODOs and replace the shared instance in the FolioReaderKit class

9bbe04f

Refactor the readerCenter and global book entity

b16196d

ReaderContainer: improve usage

88da69d

Refactor reader config

e7c0322

Improve isDirection functions to use current readerConfig

6460b63

PageScrubbler: improve init logic and remove few optional unwrap

1d59fc9

Refactor highlightlist, scrollscrubber and chapter list

4604a53

Refactor FolioReaderFontsMenu

063bd93

Refactor FolioReaderPlayerMenu

a9dbb41

Refactor FolioReaderQuoteShare

81b2e75

Refactor FolioReaderAudioPlayer

d13cf98

Refactor FolioReaderWebView.swift

b3876c8

Highlight: remove explicit try!

f0e19e6

Database method: integrate dynamic reader configuration

9634542

Refactor HighlightStyle

c6f0e6e

Remove few todos and minor code improvment

89528a7

Merge pull request #5 from smartmobilefactory/highlight_refactor

5112b2e

Highlight refactor

remove optional for book and epubPath

3e514d2

Remove unnecessary optional for FRBook

276a370

Update todos

23f1188

PR: add doc and TODOs

8e995c2

ignoreSystemTint: remove shared readerContainer and many optional unw…

db0ed10

…rapping

Reafactor FolioReaderChapterListCell

5d87547

Remove todo

c927566

Merge pull request #6 from smartmobilefactory/refactor_reader_config

8db0395

Refactor reader config

Carthage; Update gitignore

44cd612

Merge branch 'refactor_reader_config' into remove_global_variables

f571eb0

FolioReader: convert convenience init to internal

b5fdb3f

kevindelord added 3 commits May 23, 2017 21:43

Remove commented code DBGIOS-1004

7bd273a

Add epub identifier to avoid problems between example books DBGIOS-1004

faaa348

PR: minor indentation change

6d2c60a

Hans Seiffert and others added 4 commits May 24, 2017 10:46

Merge branch 'fix_PR_comments' of github.com:smartmobilefactory/Folio…

9cb26ba

…ReaderKit into fork/master

Fix indentation with tabs to use spaces

0384a0b

Update to CocoaPods version 1.2.1

801e69d

Merge pull request #19 from smartmobilefactory/fix_PR_comments

94fe4c7

Fix PR comments DBGIOS-1004

hebertialmeida added 2 commits May 26, 2017 11:35

Fixed bar animation and not showing after couple page loads

f2ac648

The bar was not showing because now with `setup` function it add multiple times the recognizer to the view, now I remove everything before adding new one

Light refactor to have weak references of readerContainer

83a8223

Fixed tests

3b3da43

hebertialmeida mentioned this pull request May 26, 2017

Map scroll directions to actual segment indices in fonts menu #238

Merged

kevindelord reviewed May 27, 2017

View reviewed changes

hebertialmeida added 3 commits May 29, 2017 11:45

Removed forcing object

55681dd

Use weak reference

cfd5937

Removed the need for retain ReaderContainer

ef320fc

kevindelord reviewed May 30, 2017

View reviewed changes

hebertialmeida approved these changes May 30, 2017

View reviewed changes

hebertialmeida added 3 commits May 30, 2017 12:14

Updated migration guide

4fc7483

Make some methods public

c79f2ab

Updated dependencies

5fc6b3e

hebertialmeida merged commit 1ecfac6 into master May 30, 2017

hebertialmeida removed the in progress label May 30, 2017

hebertialmeida deleted the issue/140 branch May 30, 2017 16:20

revolter mentioned this pull request Jan 20, 2018

Fix horizontal scroll direction not working #305

Merged

Conversation

tschob commented May 9, 2017 • edited by revolter Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kevindelord commented May 23, 2017

Uh oh!

kevindelord commented May 23, 2017

Uh oh!

hebertialmeida commented May 26, 2017

Uh oh!

hebertialmeida commented May 26, 2017

Uh oh!

kevindelord commented May 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hebertialmeida commented May 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tschob commented May 9, 2017 •

edited by revolter

Loading