Keep download folder path when changing to 'ask for download path' and back#4101
Merged
FreeTubeBot merged 3 commits intoFreeTubeApp:developmentfrom Oct 11, 2023
Merged
Conversation
github-actions
bot
added
the
PR: waiting for review
auto-merge was automatically disabled
October 4, 2023 12:55
Head branch was pushed to by a user without write access
PikachuEXE
previously approved these changes
Oct 5, 2023
Member
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Tested:
- Set path
- Enable ask for path
- Restart app
- Disabled ask for path to confirm path still exists
- Enable ask for path
- View video, save screenshot to confirm it does ask for path
- Disable ask for path
- View video, save screenshot to confirm it does NOT ask for path & file saved
Member
|
Previously saved path is getting cleared when i cancel the prompt VirtualBoxVM_vT6PfMgVpP.mp4 |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
auto-merge was automatically disabled
October 8, 2023 08:46
Head branch was pushed to by a user without write access
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 10, 2023
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
LGTM
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer,
PikachuEXE,
absidue and
kommunarr
PikachuEXE
approved these changes
Oct 11, 2023
ChunkyProgrammer
approved these changes
Oct 11, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 17, 2023
* development: Bump webpack from 5.88.2 to 5.89.0 (FreeTubeApp#4168) Fix playlists not showing up on artist topic channels with the local API (FreeTubeApp#4129) Bump undici from 5.19.1 to 5.26.3 (FreeTubeApp#4173) Bump marked from 9.1.0 to 9.1.2 (FreeTubeApp#4171) Bump sass from 1.69.0 to 1.69.3 (FreeTubeApp#4169) Bump the eslint group with 2 updates (FreeTubeApp#4166) Bump the babel group with 2 updates (FreeTubeApp#4165) Truncate title of playlist in queue window (FreeTubeApp#4134) Wrap channel tabs as soon as there isn't enough screen space (FreeTubeApp#4139) Keep download folder path when changing to 'ask for download path' and back (FreeTubeApp#4101) Add external player support for Baka, Celluloid & Haruna (FreeTubeApp#4067) Fix error when clicking on the current quality in the DASH quality selector (FreeTubeApp#4130)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep download folder path when changing to 'ask for download path' and back
Pull Request Type
Related issue
Closes #4035
Description
Keeps a flag to ask for download path instead of checking if it's an empty string
Testing
Tried switching between the toggles and different folder paths on several videos.
Desktop