Fix error when clicking on the current quality in the DASH quality selector#4130
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Oct 11, 2023
Merged
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 10, 2023
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
LGTM
ChunkyProgrammer
approved these changes
Oct 10, 2023
PikachuEXE
approved these changes
Oct 11, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 17, 2023
* development: Bump webpack from 5.88.2 to 5.89.0 (FreeTubeApp#4168) Fix playlists not showing up on artist topic channels with the local API (FreeTubeApp#4129) Bump undici from 5.19.1 to 5.26.3 (FreeTubeApp#4173) Bump marked from 9.1.0 to 9.1.2 (FreeTubeApp#4171) Bump sass from 1.69.0 to 1.69.3 (FreeTubeApp#4169) Bump the eslint group with 2 updates (FreeTubeApp#4166) Bump the babel group with 2 updates (FreeTubeApp#4165) Truncate title of playlist in queue window (FreeTubeApp#4134) Wrap channel tabs as soon as there isn't enough screen space (FreeTubeApp#4139) Keep download folder path when changing to 'ask for download path' and back (FreeTubeApp#4101) Add external player support for Baka, Celluloid & Haruna (FreeTubeApp#4067) Fix error when clicking on the current quality in the DASH quality selector (FreeTubeApp#4130)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix error when clicking on the current quality in the DASH quality selector
Pull Request Type
Related issue
closes #3543
Description
Fixes the error that happens if you click on the DASH quality selector but don't click on one of the available qualities. The proper fix would be to use a video.js menu instead of creating one with our own HTML, but this fix works for now.
See issue for the original error and a video of it happening.
Testing
Also test that changing qualities still works.
Desktop
Additional context
The proper fix would be to use a video.js menu element instead of creating our own one with raw HTML but that doesn't seem worth changing now.