Skip to content

IV RSS Subscriptions: properly detect error channels#4407

Merged
FreeTubeBot merged 4 commits intoFreeTubeApp:developmentfrom
ChunkyProgrammer:iv-rss-detect-error-channels-properly
Mar 2, 2025
Merged

IV RSS Subscriptions: properly detect error channels#4407
FreeTubeBot merged 4 commits intoFreeTubeApp:developmentfrom
ChunkyProgrammer:iv-rss-detect-error-channels-properly

Conversation

@ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Nov 30, 2023

IV RSS Subscriptions: properly detect error channels

Pull Request Type

  • Feature Implementation

Description

This PR will properly detect channels that have errors when using RSS through the Invidious API
Depends on: iv-org/invidious#4298

Screenshots

Error channel properly showing up in list:
image

Testing

  • set api to Invidious
  • force rss
  • add an invalid subscription to your subscriptions file.
  • load subscriptions

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.19.2

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 30, 2023 04:04
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 30, 2023
@ChunkyProgrammer ChunkyProgrammer marked this pull request as draft December 1, 2023 15:07
auto-merge was automatically disabled December 1, 2023 15:07

Pull request was converted to draft

@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ChunkyProgrammer ChunkyProgrammer force-pushed the iv-rss-detect-error-channels-properly branch from 27673d9 to d3528f4 Compare February 20, 2025 14:51
@ChunkyProgrammer ChunkyProgrammer force-pushed the iv-rss-detect-error-channels-properly branch from b1fbc78 to b62890c Compare February 26, 2025 23:09
@ChunkyProgrammer ChunkyProgrammer marked this pull request as ready for review February 26, 2025 23:09
@ChunkyProgrammer ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 26, 2025
@FreeTubeBot FreeTubeBot merged commit f473228 into FreeTubeApp:development Mar 2, 2025
11 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 2, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 2, 2025

What the.... november 2023 this was opened

@ChunkyProgrammer
Copy link
Member Author

What the.... november 2023 this was opened

Took a while for the invidious pr to be merged lol

@ChunkyProgrammer ChunkyProgrammer deleted the iv-rss-detect-error-channels-properly branch March 2, 2025 18:05
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Mar 5, 2025
* fix-legacy-alone:
  Allow legacy formats to be used even when dash and audio-only are unavailable
  Fix search not working on mobile because of undefined ref (FreeTubeApp#6706)
  Bump bgutils-js from 3.1.3 to 3.2.0 (FreeTubeApp#6960)
  Bump copy-webpack-plugin from 12.0.2 to 13.0.0 (FreeTubeApp#6964)
  Bump babel-loader from 9.2.1 to 10.0.0 in the babel group (FreeTubeApp#6957)
  Bump yaml-eslint-parser from 1.2.3 to 1.3.0 in the eslint group (FreeTubeApp#6958)
  Bump lefthook from 1.11.0 to 1.11.2 (FreeTubeApp#6961)
  Bump sass from 1.85.0 to 1.85.1 (FreeTubeApp#6965)
  Bump stylelint from 16.14.1 to 16.15.0 in the stylelint group (FreeTubeApp#6959)
  Bump electron from 34.2.0 to 34.3.0 (FreeTubeApp#6962)
  Bump shaka-player from 4.13.4 to 4.13.6 (FreeTubeApp#6963)
  Translated using Weblate (Welsh)
  Fix search suggestions error for long search queries (FreeTubeApp#6955)
  Fix ctrl+click to reset playback rate not working (FreeTubeApp#6943)
  Translated using Weblate (Romanian)
  IV RSS Subscriptions: properly detect `error channels` (FreeTubeApp#4407)
  Translated using Weblate (Romanian)
  Move screenshot fallback path handling to the main process (FreeTubeApp#6945)
  Translated using Weblate (Romanian)
doublecrow pushed a commit to doublecrow/FreeTube that referenced this pull request Mar 28, 2025
)

* detect error channels properly

* use get instead of head request

* remove 500 status check

* update return
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants