Fix search suggestions error for long search queries#6955
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Mar 3, 2025
Merged
Fix search suggestions error for long search queries#6955FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 2, 2025
kommunarr
approved these changes
Mar 2, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Mar 5, 2025
* fix-legacy-alone: Allow legacy formats to be used even when dash and audio-only are unavailable Fix search not working on mobile because of undefined ref (FreeTubeApp#6706) Bump bgutils-js from 3.1.3 to 3.2.0 (FreeTubeApp#6960) Bump copy-webpack-plugin from 12.0.2 to 13.0.0 (FreeTubeApp#6964) Bump babel-loader from 9.2.1 to 10.0.0 in the babel group (FreeTubeApp#6957) Bump yaml-eslint-parser from 1.2.3 to 1.3.0 in the eslint group (FreeTubeApp#6958) Bump lefthook from 1.11.0 to 1.11.2 (FreeTubeApp#6961) Bump sass from 1.85.0 to 1.85.1 (FreeTubeApp#6965) Bump stylelint from 16.14.1 to 16.15.0 in the stylelint group (FreeTubeApp#6959) Bump electron from 34.2.0 to 34.3.0 (FreeTubeApp#6962) Bump shaka-player from 4.13.4 to 4.13.6 (FreeTubeApp#6963) Translated using Weblate (Welsh) Fix search suggestions error for long search queries (FreeTubeApp#6955) Fix ctrl+click to reset playback rate not working (FreeTubeApp#6943) Translated using Weblate (Romanian) IV RSS Subscriptions: properly detect `error channels` (FreeTubeApp#4407) Translated using Weblate (Romanian) Move screenshot fallback path handling to the main process (FreeTubeApp#6945) Translated using Weblate (Romanian)
doublecrow
pushed a commit
to doublecrow/FreeTube
that referenced
this pull request
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix search suggestions error for long search queries
Pull Request Type
Description
When a long search query was entered into the search box we were catching it before sending it to YouTube's search suggestions endpoit to avoid YouTube erroring but because we were returning
undefinedas the result, it was causing errors in FreeTube because the calling code expected an array. This pull request fixes that by returning an empty array in that case. I also got rid of the unnecessary log about the query being too long, in my mind there is no point logging an error for something that isn't actually an error, especially because the user wouldn't even see it.Screenshots
Testing
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.Desktop