Add total duration display to playlists#6657
Closed
sullivanlng wants to merge 2 commits intoFreeTubeApp:developmentfrom
Closed
Add total duration display to playlists#6657sullivanlng wants to merge 2 commits intoFreeTubeApp:developmentfrom
sullivanlng wants to merge 2 commits intoFreeTubeApp:developmentfrom
Conversation
github-actions
bot
added
the
PR: waiting for review
Closed
3 tasks
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Jan 27, 2025
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
When navigating to a creators playlist this is what i see,
VirtualBoxVM_08jgZsaMtM.mp4
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
auto-merge was automatically disabled
January 28, 2025 06:54
Head branch was pushed to by a user without write access
…fied logic, and adjusted CSS for playlists.
auto-merge was automatically disabled
January 28, 2025 07:01
Head branch was pushed to by a user without write access
sullivanlng
force-pushed
the
feature-playlist-duration-6152
branch
from
4465db8 to
7b669a2
Compare
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Jan 28, 2025
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
I dislike the placement. This is playlist info and should belong next to the other data points. Place it in between video count and Last updated on
Place it between video count and views
| seconds: totalSeconds % 60, | ||
| } | ||
|
|
||
| return new Intl.DurationFormat(locale, { style: 'short' }).format(duration) |
Member
There was a problem hiding this comment.
This should use the user's locale and fallback to english
Suggested change
| return new Intl.DurationFormat(locale, { style: 'short' }).format(duration) | |
| return new Intl.DurationFormat([this.currentLocale, 'en'], { style: 'short' }).format(duration) |
Contributor
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Contributor
|
This PR was closed because it has been stalled for 14 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Add total duration display to playlists
Pull Request Type
Related issue
closes #6152
Description
This pull request adds the total playlist duration display to the playlist info container.
Changes made:
Screenshots
After :
Testing
Approach:
Behavior Confirmed:
Desktop