Skip to content

Add playlist duration to playlist view#7007

Merged
FreeTubeBot merged 4 commits intoFreeTubeApp:developmentfrom
MarmadileManteater:feature/playlist-duration
Mar 27, 2025
Merged

Add playlist duration to playlist view#7007
FreeTubeBot merged 4 commits intoFreeTubeApp:developmentfrom
MarmadileManteater:feature/playlist-duration

Conversation

@MarmadileManteater
Copy link
Contributor

@MarmadileManteater MarmadileManteater commented Mar 14, 2025 •
edited
Loading

Add playlist duration to playlist view

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

This is based on this PR: #6657
closes #6152

Description

This PR adds the total playlist duration to the playlist-info component which is displayed within the Playlist view.

Screenshots

before after
2025-03-14-090636_hyprshot 2025-03-14-090720_hyprshot

Testing

  1. Check a creator playlist (ex: https://youtube.com/playlist?list=PL2EEDBEDC9C2BDF07 )
  2. Check a user playlist
  3. Check a playlist where none of the videos have a duration
    (This can be accomplished by adding only videos from RSS feed subscriptions to a user playlist.)
  4. Check a playlist where at least one of the videos do not have a duration
  5. Check that the localization of the duration works as expected

Desktop

  • OS: Fedora Linux w/ hyprland
  • OS Version: 41 (Workstation Edition) x86_64
  • FreeTube version: b6ba16f

@MarmadileManteater @sullivanlng
Add playlist duration to playlist view
d01ec25 
Co-authored-by: Sulliva LUONG <sullivanluong@gmail.com>
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 14, 2025 13:19
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 14, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc requested changes Mar 17, 2025
View reviewed changes
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When one short is inside an user playlist i get this error

VirtualBoxVM_regZZWhCaV

User playlist full of shorts throws an error in the console

VirtualBoxVM_V7UIuZ9Psi.mp4

Couldnt find a creator playlist that had shorts without timestamp and normal videos mixed

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Mar 17, 2025
@MarmadileManteater
Copy link
Contributor Author

MarmadileManteater commented Mar 18, 2025

I'm not able to replicate, but it seems there is a video in that playlist with a non-number for lengthSeconds which is also not undefined. I pushed a change which may address the issue.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 19, 2025 •
edited
Loading

Errors are gone but when a short is added to a playlist the it wont show total time anymore. To me it seems like a harsh penalty for having shorts without timestamps within the playlist. I totally accept if these are the limitations we cant circumvent though

VirtualBoxVM_PtnY6raIhA.mp4

@MarmadileManteater
Copy link
Contributor Author

MarmadileManteater commented Mar 19, 2025

That was the behavior I intended, but it can be changed. My logic is that, if there are any number of videos with no duration in a playlist, the total duration will be wrong.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 19, 2025

Sounds logical. One thing i came up with is to call it approximately total time so we can still show it but maybe that is just bad UX

@PikachuEXE
Copy link
Member

PikachuEXE commented Mar 20, 2025

I feel like putting it to another line would make it "less busy"/easier to read
image
image
image
image
image

@MarmadileManteater
Copy link
Contributor Author

MarmadileManteater commented Mar 20, 2025

@PikachuEXE
Do you have any opinion on whether we should include playlist duration when there are videos without a length in a playlist? (or if that should be displayed as approximate time)

@PikachuEXE
Copy link
Member

PikachuEXE commented Mar 20, 2025

Don't show it seems better UX for now
Otherwise got to show how many videos have/have no length which I guess might look weird/confusing to users

@MarmadileManteater MarmadileManteater added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Mar 21, 2025
@FreeTubeBot FreeTubeBot merged commit b950658 into FreeTubeApp:development Mar 27, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 27, 2025
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Mar 29, 2025
@PikachuEXE
Merge branch 'fix/duplicate-search-term' into custom-builds/current
6dc61e4 
* fix/duplicate-search-term:
  ! Fix being able to have duplicate keyword search history due to spaces
  Translated using Weblate (Arabic)
  Translated using Weblate (Russian)
  Translated using Weblate (Basque)
  Translated using Weblate (Finnish)
  Translated using Weblate (Czech)
  Translated using Weblate (Portuguese (Brazil))
  Translated using Weblate (French)
  Update electron-builder to 26.0.12 (FreeTubeApp#7084)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Swedish)
  Translated using Weblate (Estonian)
  Translated using Weblate (Swedish)
  Translated using Weblate (Portuguese (Brazil))
  Translated using Weblate (Italian)
  Translated using Weblate (Portuguese (Brazil))
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (German)
  Add playlist duration to playlist view (FreeTubeApp#7007)
  Translated using Weblate (French)
Closed
3 tasks
Closed
3 tasks
@caetano-dev caetano-dev mentioned this pull request Aug 9, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Let the user know how much time it would take to watch an entire playlist

5 participants

@MarmadileManteater @efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE @absidue @FreeTubeBot