Implement context menu item "search X in new window"#7477
Merged
FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom Jun 1, 2025
Merged
Implement context menu item "search X in new window"#7477FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom
FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom
Conversation
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
requested review from
ChunkyProgrammer,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
Nitpick about placement: Could you place this above the inspect element option. This would make it more in line with how its seen in browsers + seems more logical to me
Member
|
@efb4f5ff-1298-471a-8973-3d47447115dc Inspect Element is only there in dev mode, so users don't see it. |
Member
Author
|
If you want to test in prod mode not dev mode and don't want to build one yourself use https://github.com/PikachuEXE/FreeTube/actions/runs/15290007172 |
Member
|
it would be nice to see if character limit toast pops up -> #4992 if user tries to search a wall of text |
Member
Author
|
Instead of toast I just disable the item with a different text
|
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 29, 2025
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
That's an elegant solution, LGTM!
absidue
approved these changes
May 30, 2025
kommunarr
approved these changes
Jun 1, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to palharesf/FreeTube
that referenced
this pull request
Jun 6, 2025
* development: (50 commits) add rules to issue templates (FreeTubeApp#7516) Translated using Weblate (Romanian) Translated using Weblate (Serbian) Translated using Weblate (Russian) Move settings to `more` menu on smaller mobile devices (FreeTubeApp#7506) Translated using Weblate (Russian) Migrate WatchVideoLiveChat to the composition API (FreeTubeApp#7494) Translated using Weblate (Basque) Translated using Weblate (Russian) Bump shaka-player from 4.14.14 to 4.14.15 (FreeTubeApp#7501) Bump electron from 36.3.1 to 36.3.2 (FreeTubeApp#7500) Bump sass from 1.89.0 to 1.89.1 (FreeTubeApp#7499) Bump the eslint group with 3 updates (FreeTubeApp#7498) Bump the stylelint group with 2 updates (FreeTubeApp#7497) Bump @babel/core from 7.27.1 to 7.27.4 in the babel group (FreeTubeApp#7496) Translated using Weblate (Japanese) Translated using Weblate (German) Implement context menu item "search X in new window" (FreeTubeApp#7477) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (French) ... # Conflicts: # static/locales/da.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
N/A
Description
This PR enables searching in a new window via selecting text and right clicking on text or link with custom text (e.g. hashtag links)
Screenshots
Places with this menu item
Places without
Char limit
Testing
Desktop
Additional context
See
parametersat https://www.electronjs.org/docs/latest/api/web-contentsSee context menu doc at https://github.com/sindresorhus/electron-context-menu