Migrate WatchVideoLiveChat to the composition API#7494
Merged
FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom Jun 3, 2025
Merged
Migrate WatchVideoLiveChat to the composition API#7494FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom
FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Jun 1, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
Member
Author
|
Fixed the undefined errors, the shallowReactive warning can be ignored just like in previous PRs as we are not using it in the way that the warning warns about. |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 1, 2025
ChunkyProgrammer
added
PR: waiting for review
PikachuEXE
approved these changes
Jun 2, 2025
ChunkyProgrammer
approved these changes
Jun 3, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to palharesf/FreeTube
that referenced
this pull request
Jun 6, 2025
* development: (50 commits) add rules to issue templates (FreeTubeApp#7516) Translated using Weblate (Romanian) Translated using Weblate (Serbian) Translated using Weblate (Russian) Move settings to `more` menu on smaller mobile devices (FreeTubeApp#7506) Translated using Weblate (Russian) Migrate WatchVideoLiveChat to the composition API (FreeTubeApp#7494) Translated using Weblate (Basque) Translated using Weblate (Russian) Bump shaka-player from 4.14.14 to 4.14.15 (FreeTubeApp#7501) Bump electron from 36.3.1 to 36.3.2 (FreeTubeApp#7500) Bump sass from 1.89.0 to 1.89.1 (FreeTubeApp#7499) Bump the eslint group with 3 updates (FreeTubeApp#7498) Bump the stylelint group with 2 updates (FreeTubeApp#7497) Bump @babel/core from 7.27.1 to 7.27.4 in the babel group (FreeTubeApp#7496) Translated using Weblate (Japanese) Translated using Weblate (German) Implement context menu item "search X in new window" (FreeTubeApp#7477) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (French) ... # Conflicts: # static/locales/da.yaml
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 10, 2025
…urrent * fix/electron-video-playback-error: (25 commits) Bump electron-builder from 26.0.15 to 26.0.16 (FreeTubeApp#7539) Bump eslint-plugin-vue from 10.1.0 to 10.2.0 in the eslint group (FreeTubeApp#7537) Bump webpack-dev-server from 5.2.1 to 5.2.2 (FreeTubeApp#7538) Bump electron from 36.3.2 to 36.4.0 (FreeTubeApp#7540) Translated using Weblate (Hungarian) Migrate FtPlaylistAddVideoPrompt and FtPlaylistSelector to the composition API (FreeTubeApp#7511) Speed up the loading of the geolocation data (FreeTubeApp#7527) Remove unnecessary barrel file in store (FreeTubeApp#7522) Translated using Weblate (Bulgarian) add rules to issue templates (FreeTubeApp#7516) Translated using Weblate (Romanian) Translated using Weblate (Serbian) Translated using Weblate (Russian) Move settings to `more` menu on smaller mobile devices (FreeTubeApp#7506) Translated using Weblate (Russian) Migrate WatchVideoLiveChat to the composition API (FreeTubeApp#7494) Translated using Weblate (Basque) Translated using Weblate (Russian) Bump shaka-player from 4.14.14 to 4.14.15 (FreeTubeApp#7501) Bump electron from 36.3.1 to 36.3.2 (FreeTubeApp#7500) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This pull request migrates the
WatchVideoLiveChatcomponent to the composition API.Testing
Find a video with a live chat such as the lofi girl one.
Desktop