Remove unnecessary barrel file in store#7522
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Jun 7, 2025
Merged
Remove unnecessary barrel file in store#7522FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Jun 6, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 7, 2025
kommunarr
approved these changes
Jun 7, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 10, 2025
…urrent * fix/electron-video-playback-error: (25 commits) Bump electron-builder from 26.0.15 to 26.0.16 (FreeTubeApp#7539) Bump eslint-plugin-vue from 10.1.0 to 10.2.0 in the eslint group (FreeTubeApp#7537) Bump webpack-dev-server from 5.2.1 to 5.2.2 (FreeTubeApp#7538) Bump electron from 36.3.2 to 36.4.0 (FreeTubeApp#7540) Translated using Weblate (Hungarian) Migrate FtPlaylistAddVideoPrompt and FtPlaylistSelector to the composition API (FreeTubeApp#7511) Speed up the loading of the geolocation data (FreeTubeApp#7527) Remove unnecessary barrel file in store (FreeTubeApp#7522) Translated using Weblate (Bulgarian) add rules to issue templates (FreeTubeApp#7516) Translated using Weblate (Romanian) Translated using Weblate (Serbian) Translated using Weblate (Russian) Move settings to `more` menu on smaller mobile devices (FreeTubeApp#7506) Translated using Weblate (Russian) Migrate WatchVideoLiveChat to the composition API (FreeTubeApp#7494) Translated using Weblate (Basque) Translated using Weblate (Russian) Bump shaka-player from 4.14.14 to 4.14.15 (FreeTubeApp#7501) Bump electron from 36.3.1 to 36.3.2 (FreeTubeApp#7500) ...
PikachuEXE
added a commit
to palharesf/FreeTube
that referenced
this pull request
Jun 16, 2025
* development: Translated using Weblate (English (United Kingdom)) add beta to asset name (FreeTubeApp#7512) Translated using Weblate (Dutch) Translated using Weblate (Dutch) Fix builds failing due to broken Weblate keys (FreeTubeApp#7560) Translated using Weblate (Persian) Translated using Weblate (Welsh) Migrate FtListVideoLazy to the composition API (FreeTubeApp#7534) Bump electron-builder from 26.0.15 to 26.0.16 (FreeTubeApp#7539) Bump eslint-plugin-vue from 10.1.0 to 10.2.0 in the eslint group (FreeTubeApp#7537) Bump webpack-dev-server from 5.2.1 to 5.2.2 (FreeTubeApp#7538) Bump electron from 36.3.2 to 36.4.0 (FreeTubeApp#7540) Translated using Weblate (Hungarian) Migrate FtPlaylistAddVideoPrompt and FtPlaylistSelector to the composition API (FreeTubeApp#7511) Speed up the loading of the geolocation data (FreeTubeApp#7527) Remove unnecessary barrel file in store (FreeTubeApp#7522) Translated using Weblate (Bulgarian) # Conflicts: # static/locales/fa.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
The
src/renderer/store/modules/index.jsfile's only purpose was to rexport from other files. This pull request imports from those files directly avoiding the need for that intermediary file. While yes this won't massively speed up the build or IDE performance, one less file to read, parse and watch is still worth it in my mind, especially when there are no downsides (the store file is still easily readable it is just 37 lines of easily understandable code).Desktop