Promote firewall policy with rules resources to GA

[mihhalj]

Promote firewall policy with rules resources to GA

See Write release notes for guidance.

- `google_compute_region_network_firewall_policy_with_rules`, `google_compute_network_firewall_policy_with_rules`,  `compute_firewall_policy_with_rules` GA promotion 

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[mihhalj]

src_network_scope/dest_network_scope fields are going to be deprecated and replace with src_network_type/dest_network_type (that's why they were removed from the examples - I didn't create examples for these fields (they are in beta only) because we don't want to advertise them much (they are going to be deprecated anyway)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 7839 insertions(+), 167 deletions(-))
google-beta provider: Diff ( 9 files changed, 18 insertions(+), 356 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1158
Passed tests: 1075
Skipped tests: 79
Affected tests: 4

Click here to see the affected service packages

• compute

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
• TestAccComputeFirewallPolicyWithRules_update
• TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeNetworkFirewallPolicyWithRules_update
• TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeRegionNetworkFirewallPolicyWithRules_update

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
• TestAccComputeFirewallPolicyWithRules_update
• TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample [Debug log]
TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[mihhalj]

gentle ping

[github-actions]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[BBBmau]

can you address the merge conflicts on this PR?

[mihhalj]

gentle ping

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[mihhalj]

@BBBmau Could I ask for review please?

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 6 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 7872 insertions(+), 162 deletions(-))
google-beta provider: Diff ( 9 files changed, 24 insertions(+), 346 deletions(-))

Multiple resources added

This PR adds multiple new resources: google_compute_firewall_policy_with_rules, google_compute_network_firewall_policy_with_rules, google_compute_region_network_firewall_policy_with_rules. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1196
Passed tests: 1111
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

• compute

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
• TestAccComputeFirewallPolicyWithRules_update
• TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeNetworkFirewallPolicyWithRules_update
• TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeRegionNetworkFirewallPolicyWithRules_update

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
• TestAccComputeFirewallPolicyWithRules_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[BBBmau]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 7872 insertions(+), 162 deletions(-))
google-beta provider: Diff ( 9 files changed, 24 insertions(+), 346 deletions(-))

Multiple resources added

This PR adds multiple new resources: google_compute_firewall_policy_with_rules, google_compute_network_firewall_policy_with_rules, google_compute_region_network_firewall_policy_with_rules. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1196
Passed tests: 1111
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

• compute

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
• TestAccComputeFirewallPolicyWithRules_update
• TestAccComputeNetworkFirewallPolicyWithRules_computeNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeNetworkFirewallPolicyWithRules_update
• TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample
• TestAccComputeRegionNetworkFirewallPolicyWithRules_update

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
• TestAccComputeFirewallPolicyWithRules_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[BBBmau]

approving after running TeamCity builds here, all passing

[rileykarson]

FYI @BBBmau the test failure here only happens in the beta provider and merging through potentially introduced a regression impacting end users: hashicorp/terraform-provider-google#23034 hashicorp/terraform-provider-google#23033

(An upstream beta run would have failed here, although an upstream GA would succeed as yours did!)