Skip to content

remove service_folder_identity from ga provider#13570

Merged
zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
ScottSuarez:cherry-pick-april-7
Apr 7, 2025
Merged

remove service_folder_identity from ga provider#13570
zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
ScottSuarez:cherry-pick-april-7

Conversation

@ScottSuarez
Copy link
Copy Markdown
Contributor

@ScottSuarez
Copy link
Copy Markdown
Contributor Author

Hello @yerniyazN notice that this test was failing in GA and this resource needs to be removed from the GA provider

Copy link
Copy Markdown
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, that makes sense. project_service_identity is also beta-only.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 4 insertions(+), 201 deletions(-))
google-beta provider: Diff ( 1 file changed, 4 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_folder_service_identity was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Copy link
Copy Markdown
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 added the override-breaking-change Allows a potential breaking change to be merged label Apr 7, 2025
@zli82016 zli82016 added this pull request to the merge queue Apr 7, 2025
@ScottSuarez ScottSuarez changed the title remove service_folder_identity from ga provider and add note to mlengine_model remove service_folder_identity from ga provider Apr 7, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 63633ac Apr 7, 2025
19 of 20 checks passed
Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025
pandirigoog pushed a commit to pandirigoog/magic-modules that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

override-breaking-change Allows a potential breaking change to be merged service/iam-serviceaccount

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants