Removing folder policy orchestrator tests from ga provider#14019
Removing folder policy orchestrator tests from ga provider#14019NickElliot merged 9 commits intoGoogleCloudPlatform:mainfrom
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
…modules into policy_orchestrator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
…modules into policy_orchestrator
…modules into policy_orchestrator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
…modules into policy_orchestrator
…modules into policy_orchestrator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 6 Click here to see the affected service packages
🟢 All tests passed! View the build log |
…modules into policy_orchestrator
…modules into policy_orchestrator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 6 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
@NickElliot , this is to address the failing tests for osconfig v2 policy orchestrator resource on folder level. More context: a. For project level and org level, we have setup project and organization for our tests. The service identities (P4SAs) are setup already there, and tests run successfully. Since folder level tests require P4SAs, it depends on |
NickElliot
left a comment
There was a problem hiding this comment.
yeah, if these cant be ran in GA and an override to breaking change remove them from GA already happened, makes sense to disable the tests.
e8e3c4f
fixes hashicorp/terraform-provider-google#22518