Skip to content

refactor more templates that no longer need to be#14060

Merged
ScottSuarez merged 2 commits intoGoogleCloudPlatform:mainfrom
ScottSuarez:rename-templates
May 22, 2025
Merged

refactor more templates that no longer need to be#14060
ScottSuarez merged 2 commits intoGoogleCloudPlatform:mainfrom
ScottSuarez:rename-templates

Conversation

@ScottSuarez
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))

Copy link
Copy Markdown
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs gofmt

@melinath
Copy link
Copy Markdown
Member

how did these make it past the checker?

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1200
Passed tests: 1115
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages
  • compute
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
  • TestAccComputeFirewallPolicyWithRules_update

Get to know how VCR tests work

@ScottSuarez
Copy link
Copy Markdown
Contributor Author

how did these make it past the checker?

checks are run on user commit, they were based on old commit.

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@melinath
Copy link
Copy Markdown
Member

oh right, it's not a merge queue blocker

@ScottSuarez ScottSuarez requested a review from melinath May 21, 2025 23:33
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))

@ScottSuarez ScottSuarez enabled auto-merge May 21, 2025 23:46
@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1200
Passed tests: 1115
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages
  • compute
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
  • TestAccComputeFirewallPolicyWithRules_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@ScottSuarez ScottSuarez added this pull request to the merge queue May 22, 2025
Merged via the queue into GoogleCloudPlatform:main with commit abc6d28 May 22, 2025
24 of 25 checks passed
@ScottSuarez ScottSuarez deleted the rename-templates branch May 22, 2025 16:45
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants