add Flex AutoTier support for storagePool and Volume by sahil-mahajan-google · Pull Request #13985 · GoogleCloudPlatform/magic-modules

sahil-mahajan-google · 2025-05-16T05:58:48Z

netapp: added `enableHotTierAutoResize` and `hotTierSizeGib` fields to `google_netapp_storage_pool` resource (beta)

netapp: added `hotTierBypassModeEnabled` field to `google_netapp_volume` resource (beta)

github-actions · 2025-05-16T05:59:49Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-05-16T06:11:38Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 224 insertions(+))
google-beta provider: Diff ( 8 files changed, 316 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_storage_pool (18 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_storage_pool" "primary" {
  enable_hot_tier_auto_resize = # value needed
  hot_tier_size_gib           = # value needed
}

Resource: google_netapp_volume (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume" "primary" {
  tiering_policy {
    hot_tier_bypass_mode_enabled = # value needed
  }
}

modular-magician · 2025-05-16T06:13:18Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update
TestAccNetappVolume_flexAutoTierNetappVolume_update
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-05-19T06:20:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 15 insertions(+))
google-beta provider: Diff ( 8 files changed, 312 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume" "primary" {
  tiering_policy {
    hot_tier_bypass_mode_enabled = # value needed
  }
}

modular-magician · 2025-05-19T07:13:28Z

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-19T07:13:48Z

🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update [Error message] [Debug log]
TestAccNetappVolume_flexAutoTierNetappVolume_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-19T09:55:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 15 insertions(+))
google-beta provider: Diff ( 8 files changed, 312 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume" "primary" {
  tiering_policy {
    hot_tier_bypass_mode_enabled = # value needed
  }
}

modular-magician · 2025-05-19T10:49:55Z

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-19T10:50:32Z

🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update [Error message] [Debug log]
TestAccNetappVolume_flexAutoTierNetappVolume_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-19T15:36:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 15 insertions(+))
google-beta provider: Diff ( 8 files changed, 312 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume" "primary" {
  tiering_policy {
    hot_tier_bypass_mode_enabled = # value needed
  }
}

modular-magician · 2025-05-19T16:29:24Z

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-19T17:01:09Z

🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update [Error message] [Debug log]
TestAccNetappVolume_flexAutoTierNetappVolume_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-20T05:41:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 15 insertions(+))
google-beta provider: Diff ( 8 files changed, 312 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume" "primary" {
  tiering_policy {
    hot_tier_bypass_mode_enabled = # value needed
  }
}

modular-magician · 2025-05-20T06:34:22Z

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-20T07:05:27Z

🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update [Error message] [Debug log]
TestAccNetappVolume_flexAutoTierNetappVolume_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-20T07:32:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 15 insertions(+))
google-beta provider: Diff ( 8 files changed, 314 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

modular-magician · 2025-05-20T07:36:40Z

Tests analytics

Total tests: 28
Passed tests: 7
Skipped tests: 0
Affected tests: 21

Click here to see the affected service packages

Action taken

Found 21 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-20T08:06:20Z

🔴 Tests failed during RECORDING mode:
TestAccNetappBackup_NetappBackupFull_update [Error message] [Debug log]
TestAccNetappBackup_NetappFlexBackup [Error message] [Debug log]
TestAccNetappBackup_NetappIntegratedBackup [Error message] [Debug log]
TestAccNetappBackup_netappBackupExample [Error message] [Debug log]
TestAccNetappStoragePool_FlexRegionalStoragePoolCreateExample_update [Error message] [Debug log]
TestAccNetappStoragePool_FlexRegionalStoragePoolNoZone [Error message] [Debug log]
TestAccNetappStoragePool_autoTieredStoragePoolCreateExample_update [Error message] [Debug log]
TestAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update [Error message] [Debug log]
TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update [Error message] [Debug log]
TestAccNetappStoragePool_storagePoolCreateExample [Error message] [Debug log]
TestAccNetappStoragePool_storagePoolCreateExample_update [Error message] [Debug log]
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample [Error message] [Debug log]
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample_update [Error message] [Debug log]
TestAccNetappVolumeReplication_NetappVolumeReplicationCreateExample_update [Error message] [Debug log]
TestAccNetappVolumeReplication_netappVolumeReplicationCreateExample [Error message] [Debug log]
TestAccNetappVolumeSnapshot_volumeSnapshotCreateExample [Error message] [Debug log]
TestAccNetappVolumeSnapshot_volumeSnapshotCreateExample_update [Error message] [Debug log]
TestAccNetappVolume_NetappVolumeBasicExample_update [Error message] [Debug log]
TestAccNetappVolume_autoTieredNetappVolume_update [Error message] [Debug log]
TestAccNetappVolume_flexAutoTierNetappVolume_update [Error message] [Debug log]
TestAccNetappVolume_netappVolumeBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-21T06:20:15Z

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-21T06:29:16Z

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_autoTieredNetappVolume_update [Error message] [Debug log]
TestAccNetappVolume_flexAutoTierNetappVolume_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-21T09:37:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 23 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 8 files changed, 325 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

modular-magician · 2025-05-21T10:30:39Z

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-21T10:39:51Z

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_autoTieredNetappVolume_update [Error message] [Debug log]
TestAccNetappVolume_flexAutoTierNetappVolume_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-22T05:29:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 23 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 8 files changed, 325 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

modular-magician · 2025-05-22T05:35:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 23 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 8 files changed, 326 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

modular-magician · 2025-05-22T05:38:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 23 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 8 files changed, 326 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

modular-magician · 2025-05-22T06:22:10Z

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-22T06:28:57Z

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-22T06:31:08Z

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-22T06:33:39Z

🟢 Tests passed during RECORDING mode:
TestAccNetappVolume_flexAutoTierNetappVolume_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_autoTieredNetappVolume_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-22T06:41:08Z

🟢 Tests passed during RECORDING mode:
TestAccNetappVolume_flexAutoTierNetappVolume_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_autoTieredNetappVolume_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-22T06:44:06Z

🟢 Tests passed during RECORDING mode:
TestAccNetappVolume_flexAutoTierNetappVolume_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_autoTieredNetappVolume_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

zli82016 · 2025-05-22T16:55:16Z

#14060 (#14062 is closed) is merged to the main branch. Please rebase the main branch to fix the unit tests.

modular-magician · 2025-05-22T18:00:11Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 23 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 8 files changed, 326 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

modular-magician · 2025-05-22T18:01:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 23 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 8 files changed, 326 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

modular-magician · 2025-05-22T18:53:47Z

Tests analytics

Total tests: 28
Passed tests: 27
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-22T18:54:41Z

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_autoTieredNetappVolume_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-22T18:54:58Z

Tests analytics

Total tests: 28
Passed tests: 27
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-05-22T18:56:10Z

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_autoTieredNetappVolume_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

sahil-mahajan-google · 2025-05-23T05:08:00Z

Duplicate of #14075

sahil-mahajan-google added 2 commits May 15, 2025 09:22

add Flex AutoTier support for storagePool and Volume

613d0c6

Merge branch 'GoogleCloudPlatform:main' into netapp_flex_autotier

61b4c0e

github-actions bot requested a review from NickElliot May 16, 2025 05:59

modular-magician added the service/netapp label May 16, 2025

sahil-mahajan-google added 2 commits May 16, 2025 12:02

change storage pool and volume test files to tmpl for beta test

69f5b6e

Fix NetappBasePath not found error

e10be60

Merge branch 'GoogleCloudPlatform:main' into netapp_flex_autotier

0d66bfb

Change test location to us-south1-a

5d09802

Minor fix in test fields

6010554

add default_value field

f7d17c7

sahil-mahajan-google added 2 commits May 20, 2025 14:24

Remove default value since it is affecting all tests

88406d7

Add update mask for hotTierBypassModeEnabled

63157c8

change region of autotiering test to us-central1

4c5e71c

sahil-mahajan-google added 3 commits May 22, 2025 10:46

Change PO autotiering test location to us-south1

3a15ce8

add provider beta

ab9b8db

Merge branch 'GoogleCloudPlatform:main' into netapp_flex_autotier

641893b

sahil-mahajan-google added 2 commits May 22, 2025 23:17

Merge branch 'GoogleCloudPlatform:main' into netapp_flex_autotier

4b13751

change autotier PO test location to us-east4

7af7dff

add time_sleep to fix network PSA issue

96c00ea

sahil-mahajan-google closed this May 23, 2025

Conversation

sahil-mahajan-google commented May 16, 2025

Uh oh!

github-actions bot commented May 16, 2025

Uh oh!

modular-magician commented May 16, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented May 16, 2025

Tests analytics

Uh oh!

modular-magician commented May 19, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented May 19, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 19, 2025

Uh oh!

modular-magician commented May 19, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented May 19, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 19, 2025

Uh oh!

modular-magician commented May 19, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented May 19, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 19, 2025

Uh oh!

modular-magician commented May 20, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented May 20, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 20, 2025

Uh oh!

modular-magician commented May 20, 2025

Diff report

Uh oh!

modular-magician commented May 20, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 20, 2025

Uh oh!

modular-magician commented May 21, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 21, 2025

Uh oh!

modular-magician commented May 21, 2025

Diff report

Uh oh!

modular-magician commented May 21, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 21, 2025

Uh oh!

modular-magician commented May 22, 2025

Diff report

Uh oh!

modular-magician commented May 22, 2025