Skip to content

Add Flex AutoTiering support for storagePool and Volume#14075

Closed
sahil-mahajan-google wants to merge 0 commit intoGoogleCloudPlatform:mainfrom
sahil-mahajan-google:netapp_flex_autotiering
Closed

Add Flex AutoTiering support for storagePool and Volume#14075
sahil-mahajan-google wants to merge 0 commit intoGoogleCloudPlatform:mainfrom
sahil-mahajan-google:netapp_flex_autotiering

Conversation

@sahil-mahajan-google
Copy link
Copy Markdown
Contributor

@sahil-mahajan-google sahil-mahajan-google commented May 23, 2025

netapp: added `enable_hot_tier_auto_resize` and `hot_tier_size_gib` fields to `google_netapp_storage_pool` resource (beta)
netapp: added `tiering_policy.hot_tier_bypass_mode_enabled` field to `google_netapp_volume` resource (beta)

@github-actions github-actions bot requested a review from zli82016 May 23, 2025 03:00
@github-actions
Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 27 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 8 files changed, 330 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 28
Passed tests: 25
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • netapp
#### Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update
  • TestAccNetappVolume_autoTieredNetappVolume_update
  • TestAccNetappVolume_flexAutoTierNetappVolume_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update [Debug log]
TestAccNetappVolume_autoTieredNetappVolume_update [Debug log]
TestAccNetappVolume_flexAutoTierNetappVolume_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Comment thread mmv1/products/netapp/Volume.yaml Outdated
Comment thread mmv1/third_party/terraform/services/netapp/resource_netapp_volume_test.go.tmpl Outdated
Comment thread mmv1/products/netapp/StoragePool.yaml Outdated
@zli82016
Copy link
Copy Markdown
Member

zli82016 commented May 23, 2025

I modified the release notes a little bit.

@github-actions github-actions bot requested a review from zli82016 May 26, 2025 05:57
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 27 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 8 files changed, 328 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 28
Passed tests: 27
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 28
Passed tests: 27
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 27 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 8 files changed, 329 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 28
Passed tests: 27
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 27 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 8 files changed, 329 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 28
Passed tests: 28
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • netapp
🟢 All tests passed!

View the build log

@github-actions github-actions bot requested a review from zli82016 May 28, 2025 05:36
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 27 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 8 files changed, 329 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 28
Passed tests: 27
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 27 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 8 files changed, 330 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 28
Passed tests: 27
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 27 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 8 files changed, 330 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 29
Passed tests: 29
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • netapp
🟢 All tests passed!

View the build log

Comment thread mmv1/products/netapp/StoragePool.yaml Outdated
@github-actions github-actions bot requested a review from zli82016 June 5, 2025 04:15
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 27 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 8 files changed, 370 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 29
Passed tests: 29
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • netapp
🟢 All tests passed!

View the build log

Comment thread mmv1/products/netapp/StoragePool.yaml Outdated
@github-actions github-actions bot requested a review from zli82016 June 5, 2025 16:36
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 27 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 364 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 27 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 364 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 29
Passed tests: 26
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • netapp
#### Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update
  • TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update
  • TestAccNetappStoragePool_storagePoolCreateExample_update

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 29
Passed tests: 26
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • netapp
#### Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update
  • TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update
  • TestAccNetappStoragePool_storagePoolCreateExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetappStoragePool_storagePoolCreateExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update [Error message] [Debug log]
TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update [Debug log]
TestAccNetappStoragePool_storagePoolCreateExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 27 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 364 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 27 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 364 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

@github-actions github-actions bot requested a review from zli82016 June 5, 2025 18:57
@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 29
Passed tests: 29
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • netapp
🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 29
Passed tests: 29
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • netapp
🟢 All tests passed!

View the build log

@zli82016 zli82016 added this pull request to the merge queue Jun 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 5, 2025
@zli82016
Copy link
Copy Markdown
Member

zli82016 commented Jun 5, 2025

@sahil-mahajan-google , can you resolve the conflicts? Sorry about that.

@github-actions github-actions bot requested a review from zli82016 June 6, 2025 01:03
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 19 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 356 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 19 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 356 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 31 insertions(+))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants