Fix dns_record_set with failover example#14310
Fix dns_record_set with failover example#14310trodge merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
Hi, I ran acceptance tests by following this https://googlecloudplatform.github.io/magic-modules/test/run-tests but I am not sure how to run the change in the example. I am pretty sure it fixes the problem, but I dont how to test. Any help is appreciated on how to test this. |
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Because this resource is handwritten there isn't a 1:1 correspondence between tests and examples. It looks like the equivalent test changes were already made. I was able to confirm via manual testing (running |
afb40a9
|
Thanks for the help. |
Fixes hashicorp/terraform-provider-google#19250 (b/363269342)
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.