Skip to content

Fix dns_record_set with failover example#14310

Merged
trodge merged 1 commit intoGoogleCloudPlatform:mainfrom
nbodepudi:bug
Jun 23, 2025
Merged

Fix dns_record_set with failover example#14310
trodge merged 1 commit intoGoogleCloudPlatform:mainfrom
nbodepudi:bug

Conversation

@nbodepudi
Copy link
Copy Markdown
Member

Fixes hashicorp/terraform-provider-google#19250 (b/363269342)

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Fixed google_dns_record_set with failover example

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+))

@nbodepudi
Copy link
Copy Markdown
Member Author

Hi, I ran acceptance tests by following this https://googlecloudplatform.github.io/magic-modules/test/run-tests but I am not sure how to run the change in the example. I am pretty sure it fixes the problem, but I dont how to test. Any help is appreciated on how to test this.

@nbodepudi nbodepudi marked this pull request as ready for review June 18, 2025 21:03
@github-actions github-actions bot requested a review from trodge June 18, 2025 21:04
@github-actions
Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
Copy link
Copy Markdown

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@trodge
Copy link
Copy Markdown
Contributor

trodge commented Jun 23, 2025

Hi, I ran acceptance tests by following this https://googlecloudplatform.github.io/magic-modules/test/run-tests but I am not sure how to run the change in the example. I am pretty sure it fixes the problem, but I dont how to test. Any help is appreciated on how to test this.

Because this resource is handwritten there isn't a 1:1 correspondence between tests and examples. It looks like the equivalent test changes were already made.

I was able to confirm via manual testing (running terraform apply locally using a test project) that adding visibility = "private" to the managed zone allows the example resources to create successfully.

@trodge trodge added this pull request to the merge queue Jun 23, 2025
Merged via the queue into GoogleCloudPlatform:main with commit afb40a9 Jun 23, 2025
24 checks passed
@nbodepudi
Copy link
Copy Markdown
Member Author

Thanks for the help.

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to create google_dns_record_set with failover

3 participants