Skip to content

Fix dns record set tests#7323

Merged
shuyama1 merged 1 commit intoGoogleCloudPlatform:mainfrom
shuyama1:fix_13269
Feb 21, 2023
Merged

Fix dns record set tests#7323
shuyama1 merged 1 commit intoGoogleCloudPlatform:mainfrom
shuyama1:fix_13269

Conversation

@shuyama1
Copy link
Copy Markdown
Member

@shuyama1 shuyama1 commented Feb 17, 2023

This fixes hashicorp/terraform-provider-google#13269

Routing policies referencing internal load balancers need to be added to private zones, therefore, change the parent zone from public to private.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@shuyama1 shuyama1 requested a review from a team as a code owner February 17, 2023 23:40
@shuyama1 shuyama1 requested review from zli82016 and removed request for a team February 17, 2023 23:40
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 35 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 1 file changed, 35 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Feb 18, 2023

Tests analytics

Total tests: 2467
Passed tests 2209
Skipped tests: 256
New/modified tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the following tests
TestAccDNSRecordSet_changeRouting|TestAccDNSRecordSet_routingPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests passed during RECORDING mode:
TestAccDNSRecordSet_changeRouting[Debug log]
TestAccDNSRecordSet_routingPolicy[Debug log]

All tests passed
View the build log or the debug log for each test

Comment on lines +329 to +331
ResourceName: "google_dns_record_set.foobar",
ImportStateId: fmt.Sprintf("%s/%s/test-record.%s.hashicorptest.com./A", getTestProjectFromEnv(), zoneName, zoneName),
ImportState: true,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird indentations.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I was trying to align with ImportStateVerify: true,

Copy link
Copy Markdown
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccDNSRecordSet_*

3 participants