Randomize network name in the basic cluster#17012
Randomize network name in the basic cluster#17012rileykarson merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 5 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Fixes b/499445670
Fixes hashicorp/terraform-provider-google#26761
Description
This PR fixes a failing acceptance test caused by a hardcoded network name (
cluster-net1) colliding across test runs in the shared CI project.It replaces the hardcoded string in the
hypercomputecluster_cluster_basic.tf.tmplfile with a variable, and configures theCluster.yamlfile to inject a randomized suffix during test execution usingtest_vars_overrides.