Skip to content

Randomize network name in the basic cluster#17012

Merged
rileykarson merged 1 commit intoGoogleCloudPlatform:mainfrom
rpgoog:fix-b-499445670
Apr 8, 2026
Merged

Randomize network name in the basic cluster#17012
rileykarson merged 1 commit intoGoogleCloudPlatform:mainfrom
rpgoog:fix-b-499445670

Conversation

@rpgoog
Copy link
Copy Markdown
Contributor

@rpgoog rpgoog commented Apr 8, 2026

Fixes b/499445670
Fixes hashicorp/terraform-provider-google#26761

Description

This PR fixes a failing acceptance test caused by a hardcoded network name (cluster-net1) colliding across test runs in the shared CI project.

It replaces the hardcoded string in the hypercomputecluster_cluster_basic.tf.tmpl file with a variable, and configures the Cluster.yaml file to inject a randomized suffix during test execution using test_vars_overrides.

Randomize network name in the basic cluster test to prevent collisions

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from rileykarson April 8, 2026 00:34
@modular-magician modular-magician added service/hypercomputecluster and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 8, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 5
Passed tests: 3
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • hypercomputecluster

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample

3 participants