Randomize network name in the basic cluster#1277
Merged
modular-magician merged 1 commit intoterraform-google-modules:masterfrom Apr 8, 2026
Conversation
[upstream:f10af4258e419f60d1c2a4bc5321d1577ae097b0] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
merged commit 658f994
into
terraform-google-modules:master
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes b/499445670
Fixes hashicorp/terraform-provider-google#26761
Description
This PR fixes a failing acceptance test caused by a hardcoded network name (
cluster-net1) colliding across test runs in the shared CI project.It replaces the hardcoded string in the
hypercomputecluster_cluster_basic.tf.tmplfile with a variable, and configures theCluster.yamlfile to inject a randomized suffix during test execution usingtest_vars_overrides.Derived from GoogleCloudPlatform/magic-modules#17012