Skip to content

refactor module attribution work#4016

Merged
megan07 merged 5 commits intoGoogleCloudPlatform:masterfrom
hashicorp:megan_mod_attr_refactor
Sep 28, 2020
Merged

refactor module attribution work#4016
megan07 merged 5 commits intoGoogleCloudPlatform:masterfrom
hashicorp:megan_mod_attr_refactor

Conversation

@megan07
Copy link
Copy Markdown
Contributor

@megan07 megan07 commented Sep 25, 2020

Addresses hashicorp/terraform-provider-google#7373

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@google-cla google-cla bot added the cla: yes label Sep 25, 2020
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 569 files changed, 4647 insertions(+), 5755 deletions(-))
Terraform Beta: Diff ( 659 files changed, 5338 insertions(+), 6806 deletions(-))
TF Conversion: Diff ( 5 files changed, 37 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148621"

@megan07 megan07 force-pushed the megan_mod_attr_refactor branch from 497c069 to 0f88f91 Compare September 25, 2020 17:59
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 568 files changed, 4636 insertions(+), 5755 deletions(-))
Terraform Beta: Diff ( 658 files changed, 5326 insertions(+), 6805 deletions(-))
TF Conversion: Diff ( 4 files changed, 25 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=148625"

@modular-magician
Copy link
Copy Markdown
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@megan07 megan07 requested a review from slevenick September 28, 2020 14:01
@slevenick
Copy link
Copy Markdown
Contributor

/gcbrun

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 568 files changed, 4636 insertions(+), 5755 deletions(-))
Terraform Beta: Diff ( 658 files changed, 5326 insertions(+), 6805 deletions(-))
TF Conversion: Diff ( 4 files changed, 25 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=149155"

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceDnsManagedZone_basic|TestAccProviderMeta_setModuleName|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccComputeSnapshot_encryptionCMEK|TestAccContainerCluster_withSandboxConfig|TestAccContainerNodePool_withSandboxConfig|TestAccMonitoringDashboard_basic|TestAccMonitoringDashboard_gridLayout|TestAccMonitoringDashboard_rowLayout|TestAccMonitoringDashboard_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=149161"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants