Skip to content

Stop editing the global config object with new useragent entries#556

Merged
modular-magician merged 1 commit intoGoogleCloudPlatform:masterfrom
modular-magician:downstream-pr-c531e1e43b79dc995cd0d3fa9b9b24d0e7376984
Oct 19, 2020
Merged

Stop editing the global config object with new useragent entries#556
modular-magician merged 1 commit intoGoogleCloudPlatform:masterfrom
modular-magician:downstream-pr-c531e1e43b79dc995cd0d3fa9b9b24d0e7376984

Conversation

@modular-magician
Copy link
Copy Markdown
Collaborator

It looks like some occurrences of this were left in after GoogleCloudPlatform/magic-modules#4016. This means we'd keep appending onto the end of it while a single provider instance was alive, possibly causing issues in large applies.

Also don't append to the user agent if the m.ModuleName value is nil or empty- we would have added a space every time generateUserAgentString was called.

Notably, this breaks module attribution for batched requests. I'm pretty comfortable with that- it just affects service management and IAM, and we can fix them in a followup.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

provider: fixed an issue where the request headers would grow proportionally to the number of resources in a given `terraform apply`

Derived from GoogleCloudPlatform/magic-modules#4123

@google-cla google-cla bot added the cla: yes label Oct 19, 2020
@modular-magician modular-magician merged commit 4eefceb into GoogleCloudPlatform:master Oct 19, 2020
@modular-magician modular-magician deleted the downstream-pr-c531e1e43b79dc995cd0d3fa9b9b24d0e7376984 branch November 18, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant