deprecated existing beta fields in TPG#4632
Conversation
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=179681" |
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccNotebooksInstance_notebookInstanceFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=179711" |
|
Tests failed during RECORDING mode: TestAccNotebooksInstance_notebookInstanceFullExample Please fix these to complete your PR |
| ValidateFunc: validation.IntBetween(0, 3600), | ||
| Description: `Minimum number of seconds to wait for after a newly created instance becomes available. This value must be from range [0, 3600].`, | ||
| <% if version == "ga" -%> | ||
| Deprecated: `This is beta only attribute`, |
There was a problem hiding this comment.
Can we change these messages to something like:
"This attribute is currently in beta and will be removed from the google provider. Please use the google-beta provider to continue using this attribute."
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 4 insertions(+)) |
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=181878" |
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
fixes hashicorp/terraform-provider-google#8709