Skip to content

deprecated existing beta fields in TPG#4632

Merged
venkykuberan merged 2 commits intoGoogleCloudPlatform:masterfrom
venkykuberan:deprecate-existing-beta-fields-in-tpg-8709
Apr 21, 2021
Merged

deprecated existing beta fields in TPG#4632
venkykuberan merged 2 commits intoGoogleCloudPlatform:masterfrom
venkykuberan:deprecate-existing-beta-fields-in-tpg-8709

Conversation

@venkykuberan
Copy link
Copy Markdown
Contributor

@venkykuberan venkykuberan commented Mar 30, 2021

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: deprecated `min_ready_sec` in `google_compute_region_instance_group_manager` & `google_compute_instance_group_manager` in GA
compute: deprecated `distribution_policy_target_shape` in `google_compute_region_instance_group_manager` in GA
container: deprecated `pod_security_policy_config` field on resource `google_container_cluster` in GA

fixes hashicorp/terraform-provider-google#8709

@venkykuberan venkykuberan requested a review from slevenick March 30, 2021 03:00
@google-cla google-cla bot added the cla: yes label Mar 30, 2021
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 4 insertions(+))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=179681"

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccNotebooksInstance_notebookInstanceFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=179711"

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests failed during RECORDING mode: TestAccNotebooksInstance_notebookInstanceFullExample Please fix these to complete your PR

ValidateFunc: validation.IntBetween(0, 3600),
Description: `Minimum number of seconds to wait for after a newly created instance becomes available. This value must be from range [0, 3600].`,
<% if version == "ga" -%>
Deprecated: `This is beta only attribute`,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change these messages to something like:

"This attribute is currently in beta and will be removed from the google provider. Please use the google-beta provider to continue using this attribute."

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 4 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=181878"

@slevenick slevenick self-requested a review April 12, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate existing beta fields in TPG

3 participants