Skip to content

deprecated existing beta fields in TPG #4632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
venkykuberan merged 2 commits into from
Apr 21, 2021
Merged

deprecated existing beta fields in TPG #4632

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e3a185
deprecated existing beta fields in TPG
venkykuberan Mar 29, 2021
677a940
description updated for deprecated attributes for google provider
venkykuberan Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...esource_compute_instance_group_manager.go → ...rce_compute_instance_group_manager.go.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<% autogen_exception -%>
package google

import (
Expand Down Expand Up @@ -251,6 +252,9 @@ func resourceComputeInstanceGroupManager() *schema.Resource {
Optional: true,
ValidateFunc: validation.IntBetween(0, 3600),
Description: `Minimum number of seconds to wait for after a newly created instance becomes available. This value must be from range [0, 3600].`,
<% if version == "ga" -%>
Deprecated: `This is beta only attribute`,
Copy link
Copy Markdown
Contributor

@slevenick slevenick Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change these messages to something like:

"This attribute is currently in beta and will be removed from the google provider. Please use the google-beta provider to continue using this attribute."

<% end -%>
},
"replacement_method": {
Type: schema.TypeString,
Expand Down
7 changes: 7 additions & 0 deletions ..._compute_region_instance_group_manager.go → ...pute_region_instance_group_manager.go.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<% autogen_exception -%>
package google

import (
Expand Down Expand Up @@ -219,6 +220,9 @@ func resourceComputeRegionInstanceGroupManager() *schema.Resource {
ForceNew: true,
Computed: true,
Description: `The shape to which the group converges either proactively or on resize events (depending on the value set in updatePolicy.instanceRedistributionType).`,
<% if version == "ga" -%>
Deprecated: `This is beta only attribute`,
<% end -%>
},

"update_policy": {
Expand Down Expand Up @@ -280,6 +284,9 @@ func resourceComputeRegionInstanceGroupManager() *schema.Resource {
Optional: true,
ValidateFunc: validation.IntBetween(0, 3600),
Description: `Minimum number of seconds to wait for after a newly created instance becomes available. This value must be from range [0, 3600].`,
<% if version == "ga" -%>
Deprecated: `This is beta only attribute`,
<% end -%>
},
"instance_redistribution_type": {
Type: schema.TypeString,
Expand Down
3 changes: 3 additions & 0 deletions mmv1/third_party/terraform/resources/resource_container_cluster.go.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,6 +825,9 @@ func resourceContainerCluster() *schema.Resource {
Optional: true,
MaxItems: 1,
Description: `Configuration for the PodSecurityPolicy feature.`,
<% if version == "ga" -%>
Deprecated: `This is beta only attribute`,
<% end -%>
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"enabled": {
Expand Down