feat: add new Cloud Run tag samples#6135
Conversation
|
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 96 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccContainerCluster_withAddons|TestAccContainerCluster_withConfidentialNodes|TestAccCloudRunService_cloudRunServiceRemoveTagExample|TestAccCloudRunService_cloudRunServiceAddTagNoRevisionExample|TestAccCloudRunService_cloudRunServiceAddTagExample |
|
Tests failed during RECORDING mode: Please fix these to complete your PR |
slevenick
left a comment
There was a problem hiding this comment.
The tests fail probably because the revisions aren't set up. Is there a way to set these up from within Terraform to show a full example?
mmv1/templates/terraform/examples/cloud_run_service_remove_tag.tf.erb
Outdated
Show resolved
Hide resolved
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 98 insertions(+)) |
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 98 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccCloudRunService_cloudRunServiceAddTagNoRevisionExample|TestAccCloudRunService_cloudRunServiceAddTagExample|TestAccCloudRunService_cloudRunServiceRemoveTagExample|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons |
|
Tests failed during RECORDING mode: Please fix these to complete your PR |
|
Reassigning as I'm out |
c2thorn
left a comment
There was a problem hiding this comment.
Hey @averikitsch, sorry for the delay. Couple of things:
-
Cloud docs samples need associated region tags in the example file to appear in https://github.com/terraform-google-modules/terraform-docs-samples . See https://github.com/terraform-google-modules/terraform-docs-samples/blob/main/cloud_run_service_pubsub/main.tf#L1 as an example
-
samples don't need a release note tag in the first PR comment. you can edit the tag to be "release-note:none" and have the body be empty
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 83 insertions(+)) |
Samples for https://cloud.google.com/run/docs/rollouts-rollbacks-traffic-migration
Part of b/230161729
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)