Skip to content

feat: add new Cloud Run tag samples#6135

Merged
c2thorn merged 6 commits intoGoogleCloudPlatform:mainfrom
averikitsch:cloudrun-tag
Jun 23, 2022
Merged

feat: add new Cloud Run tag samples#6135
c2thorn merged 6 commits intoGoogleCloudPlatform:mainfrom
averikitsch:cloudrun-tag

Conversation

@averikitsch
Copy link
Copy Markdown
Contributor

@averikitsch averikitsch commented Jun 15, 2022

Samples for https://cloud.google.com/run/docs/rollouts-rollbacks-traffic-migration
Part of b/230161729

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Copy Markdown
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 96 insertions(+))
Terraform Beta: Diff ( 2 files changed, 252 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 369 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2056
Passed tests 1825
Skipped tests: 226
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccContainerCluster_withAddons|TestAccContainerCluster_withConfidentialNodes|TestAccCloudRunService_cloudRunServiceRemoveTagExample|TestAccCloudRunService_cloudRunServiceAddTagNoRevisionExample|TestAccCloudRunService_cloudRunServiceAddTagExample

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests failed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceRemoveTagExample[view]
TestAccContainerCluster_withAddons[view]
TestAccContainerCluster_withConfidentialNodes[view]
TestAccCloudRunService_cloudRunServiceAddTagNoRevisionExample[view]
TestAccCloudRunService_cloudRunServiceAddTagExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

Copy link
Copy Markdown
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests fail probably because the revisions aren't set up. Is there a way to set these up from within Terraform to show a full example?

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 98 insertions(+))
Terraform Beta: Diff ( 2 files changed, 256 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 371 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 98 insertions(+))
Terraform Beta: Diff ( 2 files changed, 256 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 371 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2056
Passed tests 1825
Skipped tests: 226
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccCloudRunService_cloudRunServiceAddTagNoRevisionExample|TestAccCloudRunService_cloudRunServiceAddTagExample|TestAccCloudRunService_cloudRunServiceRemoveTagExample|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests failed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceRemoveTagExample[view]
TestAccContainerCluster_withAddons[view]
TestAccContainerCluster_withConfidentialNodes[view]
TestAccCloudRunService_cloudRunServiceAddTagNoRevisionExample[view]
TestAccCloudRunService_cloudRunServiceAddTagExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 83 insertions(+))
Terraform Beta: Diff ( 1 file changed, 83 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@slevenick slevenick requested review from c2thorn and slevenick and removed request for slevenick June 17, 2022 17:54
@slevenick
Copy link
Copy Markdown
Contributor

Reassigning as I'm out

Copy link
Copy Markdown
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @averikitsch, sorry for the delay. Couple of things:

  1. Cloud docs samples need associated region tags in the example file to appear in https://github.com/terraform-google-modules/terraform-docs-samples . See https://github.com/terraform-google-modules/terraform-docs-samples/blob/main/cloud_run_service_pubsub/main.tf#L1 as an example

  2. samples don't need a release note tag in the first PR comment. you can edit the tag to be "release-note:none" and have the body be empty

@averikitsch averikitsch requested review from c2thorn and slevenick June 23, 2022 17:38
@averikitsch
Copy link
Copy Markdown
Contributor Author

@pattishin

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 83 insertions(+))
Terraform Beta: Diff ( 1 file changed, 83 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF Cloud Doc Samples: Diff ( 3 files changed, 74 insertions(+))

@c2thorn c2thorn removed the request for review from slevenick June 23, 2022 21:05
@c2thorn c2thorn dismissed slevenick’s stale review June 23, 2022 21:08

Request was addressed

@c2thorn c2thorn merged commit 196d165 into GoogleCloudPlatform:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants