Skip to content

feat: add new Cloud Run tag samples#4407

Merged
modular-magician merged 1 commit intohashicorp:mainfrom
modular-magician:downstream-pr-196d1656bf35bcd6bb0975e714fa69eb55c27c6c
Jun 23, 2022
Merged

feat: add new Cloud Run tag samples#4407
modular-magician merged 1 commit intohashicorp:mainfrom
modular-magician:downstream-pr-196d1656bf35bcd6bb0975e714fa69eb55c27c6c

Conversation

@modular-magician
Copy link
Copy Markdown
Collaborator

Samples for https://cloud.google.com/run/docs/rollouts-rollbacks-traffic-migration
Part of b/230161729

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#6135

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit a075d6c into hashicorp:main Jun 23, 2022
@modular-magician modular-magician deleted the downstream-pr-196d1656bf35bcd6bb0975e714fa69eb55c27c6c branch November 16, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant