Passwd build rule prototype - #16
Conversation
| @@ -0,0 +1,6 @@ | |||
| load(":passwd.bzl", "passwd_file") | |||
|
|
|||
| passwd_file( | |||
There was a problem hiding this comment.
I'll remove this, it was just for testing.
| arg_file = ctx.new_file(ctx.attr.name + ".args") | ||
| ctx.file_action(arg_file, "\n".join(args)) | ||
|
|
||
| ctx.action( |
There was a problem hiding this comment.
@damienmg What's the best way to send this through pkg_tar
There was a problem hiding this comment.
I think this is the best way, we could make it 2 rules instead of one and do the second action with pkg_tar, but why?
| @@ -0,0 +1,56 @@ | |||
| load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar") | |||
There was a problem hiding this comment.
tl;dr I think we should add this to bazelbuild/rules_docker.
Perhaps under docker/contrib for now. It should be very straightforward to add a rule that uses it under docker/testdata and verifies the result under docker/build_test.sh.
WDYT?
There was a problem hiding this comment.
Sounds reasonable to me, this is the kind of utility that people would want to have.
Also as discussed on our CI, it would be good to have a list of example / good base images for dockerless build
There was a problem hiding this comment.
SGTM. I'll move it over there with a test, then add it to our base here.
|
Closing, this was merged upstream. |
3 participants
Here's a quick version of what we discussed in #14