Add a rule for generating passwd files. - #30
Conversation
|
Can one of the admins verify this patch? |
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
I'm wondering what stance we want to take wrt adding contrib rules to the README.md...
I wonder if we want to add a docker/contrib/README.md that covers those rules... I hadn't thought about this for with-tag.bzl since the signature was so similar, but perhaps we should start this.
I think we'd probably want the form:
rule_foo (file.bzl)
| # specified via the tag kwarg. | ||
| check_layers "with_passwd" \ | ||
| "621fe329a78d65d90d34d6dc277ccac2249bba4c8228222271418bf6b07c4dec" | ||
| } |
There was a problem hiding this comment.
You should add an additional check that uses get_layer_listing to check that the passwd file is in the new layer.
|
test this please |
|
I would suggest we move the documentation to use https://github.com/bazelbuild/skydoc and we generate the doc on the gh-pages. That way we would cover the contrib part too. Pulling in @davidzchen about that. |
… text. (bazelbuild#29)" (bazelbuild#30) This reverts commit 53c7f3d.
5 participants
Ref GoogleContainerTools/distroless#16