Upgrade Java to 8u242 and 11.0.6 (from 8u232 and 11.0.5) - #470
Conversation
| sha256 = "2b13362808b7bd90d24db2e0804c799288694ae44bd7e3d123becc191451fc67", | ||
| snapshot = "20191230T150135Z", | ||
| sha256 = "56537cedf58e6f08bb3eafef514a20016fbfd227850ab810c43e5ffb00f57427", | ||
| snapshot = "20200219T150721Z", |
There was a problem hiding this comment.
If this value is always the same everywhere can we just put it in a variable at the top? Or is that not bazel-y?
There was a problem hiding this comment.
It doesn't have to be same. As you noted, it will redirect to the most recent timestamp if it doesn't exist, so perhaps it's ideal to set exact timestamps instead of having all same. I remember it used to be the case at some point. However, I found it cumbersome, so now I'm just using the same timestamp everywhere. As long as it works, I think this is convenient. For this reason, I do not really want to put this in a variable.
There was a problem hiding this comment.
I just go to (for example) https://snapshot.debian.org/archive/debian-security/ and select the most recent timestamp.
Fixes #467.
Travis build will fail to due my mistake in #469 (comment). #469 should be merged first.UPDATE: resolved