Skip to content

Upgrade Java to 8u242 and 11.0.6 (from 8u232 and 11.0.5) - #470

Merged
chanseokoh merged 4 commits into
masterfrom
upgrade-java-11
Feb 20, 2020
Merged

Upgrade Java to 8u242 and 11.0.6 (from 8u232 and 11.0.5)#470
chanseokoh merged 4 commits into
masterfrom
upgrade-java-11

Conversation

@chanseokoh

@chanseokoh chanseokoh commented Feb 19, 2020

Copy link
Copy Markdown
Member

Fixes #467.

Travis build will fail to due my mistake in #469 (comment). #469 should be merged first. UPDATE: resolved

@chanseokoh chanseokoh changed the title Upgrade Java 11 from 11.0.5 to 11.0.6 Upgrade Java from to 8u242 and 11.0.6 (from 8u232 and 11.0.5) Feb 19, 2020
@chanseokoh chanseokoh changed the title Upgrade Java from to 8u242 and 11.0.6 (from 8u232 and 11.0.5) Upgrade Java to 8u242 and 11.0.6 (from 8u232 and 11.0.5) Feb 19, 2020
Comment thread WORKSPACE
Comment thread WORKSPACE
sha256 = "2b13362808b7bd90d24db2e0804c799288694ae44bd7e3d123becc191451fc67",
snapshot = "20191230T150135Z",
sha256 = "56537cedf58e6f08bb3eafef514a20016fbfd227850ab810c43e5ffb00f57427",
snapshot = "20200219T150721Z",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this value is always the same everywhere can we just put it in a variable at the top? Or is that not bazel-y?

@chanseokoh chanseokoh Feb 19, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have to be same. As you noted, it will redirect to the most recent timestamp if it doesn't exist, so perhaps it's ideal to set exact timestamps instead of having all same. I remember it used to be the case at some point. However, I found it cumbersome, so now I'm just using the same timestamp everywhere. As long as it works, I think this is convenient. For this reason, I do not really want to put this in a variable.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just go to (for example) https://snapshot.debian.org/archive/debian-security/ and select the most recent timestamp.

@chanseokoh
chanseokoh merged commit fd0d99e into master Feb 20, 2020
@chanseokoh
chanseokoh deleted the upgrade-java-11 branch February 20, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes CLAs look good

Projects

None yet

Development

Successfully merging this pull request may close these issues.

distroless:java-debian10 not using latest OpenJDK 11 release

4 participants