Skip to content

Upgrade Java to 8u242 and 11.0.6 (from 8u232 and 11.0.5) #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chanseokoh merged 4 commits into from
Feb 20, 2020
Merged

Upgrade Java to 8u242 and 11.0.6 (from 8u232 and 11.0.5) #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
184facb
Update Debian package repo snapshots
chanseokoh Feb 19, 2020
0fb4787
Fix tests
chanseokoh Feb 19, 2020
0b781d0
Fix tests
chanseokoh Feb 19, 2020
026e366
Merge branch 'master' into upgrade-java-11
chanseokoh Feb 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,25 +27,25 @@ dpkg_src(
name = "debian_stretch",
arch = "amd64",
distro = "stretch",
sha256 = "2b13362808b7bd90d24db2e0804c799288694ae44bd7e3d123becc191451fc67",
snapshot = "20191230T150135Z",
sha256 = "56537cedf58e6f08bb3eafef514a20016fbfd227850ab810c43e5ffb00f57427",
snapshot = "20200219T150721Z",

@loosebazooka loosebazooka Feb 19, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this value is always the same everywhere can we just put it in a variable at the top? Or is that not bazel-y?

@chanseokoh chanseokoh Feb 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have to be same. As you noted, it will redirect to the most recent timestamp if it doesn't exist, so perhaps it's ideal to set exact timestamps instead of having all same. I remember it used to be the case at some point. However, I found it cumbersome, so now I'm just using the same timestamp everywhere. As long as it works, I think this is convenient. For this reason, I do not really want to put this in a variable.

@chanseokoh chanseokoh Feb 20, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just go to (for example) https://snapshot.debian.org/archive/debian-security/ and select the most recent timestamp.

url = "https://snapshot.debian.org/archive",
)

dpkg_src(
name = "debian_stretch_backports",
arch = "amd64",
distro = "stretch-backports",
sha256 = "ca26befa30c4cef5900e28ced7baf2f237b4d02550e00823e8c3967cb1615f8c",
snapshot = "20191230T150135Z",
sha256 = "e76dc8139979bd35c4f1c56eba1fdead249b969add88b146b64a19de87abbdcf",
snapshot = "20200219T150721Z",
url = "https://snapshot.debian.org/archive",
)

dpkg_src(
name = "debian_stretch_security",
package_prefix = "https://snapshot.debian.org/archive/debian-security/20191230T212302Z/",
packages_gz_url = "https://snapshot.debian.org/archive/debian-security/20191230T212302Z/dists/stretch/updates/main/binary-amd64/Packages.gz",
sha256 = "046a277f34b07c723f363f132eb6cb3485f25170ae426bc3ef146968b259f585",
package_prefix = "https://snapshot.debian.org/archive/debian-security/20200219T150721Z/",
packages_gz_url = "https://snapshot.debian.org/archive/debian-security/20200219T150721Z/dists/stretch/updates/main/binary-amd64/Packages.gz",
sha256 = "221c453ba67ed5eaea7ee896b183ab228c5a49ceab087ae007829e038d7ad531",
)

dpkg_list(
Expand Down Expand Up @@ -250,8 +250,8 @@ dpkg_src(
name = "debian10",
arch = "amd64",
distro = "buster",
sha256 = "6f21fb3369b618a55bac745bff10835ac96ec1a7d8ec709029c7e9f0fa44ad25",
snapshot = "20191230T150135Z",
sha256 = "889681a6f709a3872833643a2ab28aa5bf4839ec5a8994cd4382f179a6521c63",
snapshot = "20200219T150721Z",
url = "https://snapshot.debian.org/archive",
)

Expand Down Expand Up @@ -362,7 +362,7 @@ dpkg_list(

dpkg_src(
name = "debian10_security",
package_prefix = "https://snapshot.debian.org/archive/debian-security/20191230T212302Z/",
packages_gz_url = "https://snapshot.debian.org/archive/debian-security/20191230T212302Z/dists/buster/updates/main/binary-amd64/Packages.gz",
sha256 = "20299ed97c71f26e6c34d948a358e3ac9bb9f4709a90b6f38e6094b688f5270b",
package_prefix = "https://snapshot.debian.org/archive/debian-security/20200219T150721Z/",
Comment thread
chanseokoh marked this conversation as resolved.
packages_gz_url = "https://snapshot.debian.org/archive/debian-security/20200219T150721Z/dists/buster/updates/main/binary-amd64/Packages.gz",
sha256 = "59e2ff24630ddb40d3b31c51890b8ae7efe861eec3f0af8f3b7fbc27d8f36dc2",
)
2 changes: 1 addition & 1 deletion java/testdata/java11.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ fileExistenceTests:
metadataTest:
env:
- key: 'JAVA_VERSION'
value: '11.0.5'
value: '11.0.6'
2 changes: 1 addition & 1 deletion java/testdata/java11_debug.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ fileExistenceTests:
metadataTest:
env:
- key: 'JAVA_VERSION'
value: '11.0.5'
value: '11.0.6'
2 changes: 1 addition & 1 deletion java/testdata/java8.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ metadataTest:
entrypoint: ["/usr/bin/java", "-jar"]
env:
- key: 'JAVA_VERSION'
value: '8u232'
value: '8u242'
2 changes: 1 addition & 1 deletion java/testdata/java8_debug.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ metadataTest:
entrypoint: ["/usr/bin/java", "-jar"]
env:
- key: 'JAVA_VERSION'
value: '8u232'
value: '8u242'