Skip to content

fixed PropTypes warnings due to upcoming deprecation in React v15.5#654

Merged
ryanlanciaux merged 1 commit into
GriddleGriddle:masterfrom
followbl:issue-651
May 4, 2017
Merged

fixed PropTypes warnings due to upcoming deprecation in React v15.5#654
ryanlanciaux merged 1 commit into
GriddleGriddle:masterfrom
followbl:issue-651

Conversation

@followbl

@followbl followbl commented May 3, 2017

Copy link
Copy Markdown
Contributor

#651

There's still an error in the console on the storybook...but after this, it's been determined the culprit is a non-upgraded dependency in @kadira/storybook

yarn why v0.23.3
[1/4] 🤔  Why do we have the module "react-inspector"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
info This module exists because "@kadira/storybook#@kadira/storybook-addon-actions" depends on it.
info Disk size without dependencies: "208kB"
info Disk size with unique dependencies: "1.23MB"
info Disk size with transitive dependencies: "20MB"
info Amount of shared dependencies: 32
✨  Done in 0.97s.```

@followbl

followbl commented May 3, 2017

Copy link
Copy Markdown
Contributor Author

to be clear, this does fix the console errors in the Griddle package, which was the goal of this PR/issue ;)

@dahlbyk dahlbyk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Strange that the yarn.lock update seems to include some dependencies that were just moved around but not changed.

@followbl

followbl commented May 4, 2017

Copy link
Copy Markdown
Contributor Author

@dahlbyk yea. funny enough I blew away the yarn.lock and added prop-types a second time and it insisted on updating the yarn.lock file like so...I agree, weird

@ryanlanciaux ryanlanciaux merged commit 794064e into GriddleGriddle:master May 4, 2017
@ryanlanciaux

Copy link
Copy Markdown
Member

Awesome thank you!

@juampick

juampick commented May 5, 2017

Copy link
Copy Markdown

Hi! Thanks for this update. Do you know @ryanlanciaux when are we going to have a new release version? I'm using 1.4.0 and still has this issue.

Thanks a lot.

@dahlbyk dahlbyk mentioned this pull request Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants