@types/prop-types#827
Merged
Merged
Conversation
Closed
dahlbyk
commented
Aug 9, 2018
| language: node_js | ||
| node_js: | ||
| - '5' | ||
| - '9' |
Contributor
Author
There was a problem hiding this comment.
Looks like build tooling has taken a dependency on object spread.
Member
There was a problem hiding this comment.
Ahh yea we're a few versions behind on node there :D
|
|
||
| branches: | ||
| only: | ||
| - master |
Contributor
Author
There was a problem hiding this comment.
Minor pet peeve when Travis push and pr builds both run. 😀
ryanlanciaux
approved these changes
Aug 12, 2018
ryanlanciaux
left a comment
ryanlanciaux
left a comment
Member
There was a problem hiding this comment.
This looks good and I should clean up some things that were around for awhile as well as addresses the import with PropTypes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Griddle major version
1.13.1
Changes proposed in this pull request
PropTypes(fixed PropTypes warnings due to upcoming deprecation in React v15.5 #654)TableContainerstory, from a simpler time (f70a712)Why these changes are made
Fixes #826
Are there tests?
Compiler!