fix: install conventionalcommits preset for semantic-release - #56
Merged
Merged
Conversation
The Release workflow failed at the Semantic Release step with "Cannot find module 'conventional-changelog-conventionalcommits'". `.releaserc.json` configures @semantic-release/release-notes-generator with `preset: "conventionalcommits"`, but that preset package is not a dependency of release-notes-generator (it ships only conventional-changelog-angular), and the action only installs the plugins listed in `extra_plugins`. Add conventional-changelog-conventionalcommits so the preset resolves at release time. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
🎉 This PR is included in version 2.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure
The first Release run after #54 merged failed at the Semantic Release step (Build passed):
Cause
.releaserc.jsonconfigures@semantic-release/release-notes-generatorwithpreset: "conventionalcommits". That preset lives in the separateconventional-changelog-conventionalcommitspackage — release-notes-generator only shipsconventional-changelog-angularas a dependency (confirmed:npm view @semantic-release/release-notes-generator@14 dependencies).cycjimmy/semantic-release-actioninstalls only the packages listed inextra_plugins, and that list didn't include the preset, so the module wasn't present at release time.Fix
Add
conventional-changelog-conventionalcommitstoextra_plugins. Unpinned, matching the workflow's existing "track latest" posture — the action installs the latest semantic-release, and the latest preset (10.2.1, which only pulls@conventional-changelog/template) is the matching pairing. This got through review originally because it's inherited verbatim from vite's workflow, which has the same latent gap.Notes
main(or via Run workflow). Nothing to build/test locally.release.yamlhas the identical gap).conventional-changelog-conventionalcommits(and semantic-release) to explicit versions here and in vite — say the word.🤖 Generated with Claude Code