fix: install conventionalcommits preset for semantic-release - #28
Merged
Merged
Conversation
.releaserc.json configures @semantic-release/release-notes-generator with `preset: "conventionalcommits"`, but that preset package is not a dependency of release-notes-generator (it ships only conventional-changelog-angular), and the action only installs the plugins listed in `extra_plugins`. Without it the Release workflow fails with "Cannot find module 'conventional-changelog-conventionalcommits'". Add it so the preset resolves. Mirrors the same fix in @harperfast/nextjs, which hit this on its first release. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
🎉 This PR is included in version 1.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preemptive fix mirroring HarperFast/nextjs#56.
.releaserc.jsonconfigures@semantic-release/release-notes-generatorwithpreset: "conventionalcommits", but that preset ships in the separateconventional-changelog-conventionalcommitspackage — release-notes-generator depends only onconventional-changelog-angular.cycjimmy/semantic-release-actioninstalls only what's inextra_plugins, which didn't include the preset, so a release fails at the Semantic Release step with:nextjs hit this on its first real release run after adopting this exact workflow; vite has the identical gap and would fail the same way on its next release. Adding
conventional-changelog-conventionalcommitstoextra_pluginsfixes it (unpinned, matching the workflow's existing "track latest" posture).Workflow-only change; no build/test impact.
🤖 Generated with Claude Code