sch-UID2-6637 add conditional defaulting for service instance count#2413
Merged
sophia-chen-ttd merged 1 commit intoMar 4, 2026
Conversation
cYKatherine
reviewed
Mar 4, 2026
| if (svcInstances == null) { | ||
| svcInstances = Runtime.getRuntime().availableProcessors(); | ||
| } | ||
| requestedServiceInstances = svcInstances; |
Contributor
There was a problem hiding this comment.
nit: Can we dorequestedServiceInstances = config.getInteger(Const.Config.ServiceInstancesProp, Runtime.getRuntime().availableProcessors());
Contributor
Author
There was a problem hiding this comment.
We can't because if we have "service_instance": null, then this will still pick up the value as null :(
The default value is only used if the key doesn't exist
cYKatherine
approved these changes
Mar 4, 2026
sophia-chen-ttd
deleted the
sch-UID2-6637-conditional-defaulting-for-service-instance-count
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If service_instance count does not exist in the config or is null, then default to the vCPU count.
Tested locally: