Skip to content

sch-UID2-6637 add conditional defaulting for service instance count #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sophia-chen-ttd merged 1 commit into from
Mar 4, 2026
Merged

sch-UID2-6637 add conditional defaulting for service instance count #2413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/main/java/com/uid2/operator/Main.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ public class Main {
private RotatingServiceLinkStore serviceLinkProvider;
private RotatingCloudEncryptionKeyApiProvider cloudEncryptionKeyProvider;
private final UidInstanceIdProvider uidInstanceIdProvider;
private final int requestedServiceInstances;

public Main(Vertx vertx, JsonObject config) throws Exception {
this.vertx = vertx;
Expand Down Expand Up @@ -243,6 +244,12 @@ public Main(Vertx vertx, JsonObject config) throws Exception {
}
}
metrics = new OperatorMetrics(getKeyManager(), saltProvider);

Integer svcInstances = config.getInteger(Const.Config.ServiceInstancesProp);
if (svcInstances == null) {
svcInstances = Runtime.getRuntime().availableProcessors();
}
requestedServiceInstances = svcInstances;

@cYKatherine cYKatherine Mar 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we dorequestedServiceInstances = config.getInteger(Const.Config.ServiceInstancesProp, Runtime.getRuntime().availableProcessors());

@sophia-chen-ttd sophia-chen-ttd Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't because if we have "service_instance": null, then this will still pick up the value as null :(
The default value is only used if the key doesn't exist

}

private KeyManager getKeyManager() {
Expand Down Expand Up @@ -346,8 +353,7 @@ private void run() throws Exception {
};

DeploymentOptions options = new DeploymentOptions();
int svcInstances = this.config.getInteger(Const.Config.ServiceInstancesProp);
options.setInstances(svcInstances);
options.setInstances(requestedServiceInstances);

Promise<Void> compositePromise = Promise.promise();
List<Future> fs = new ArrayList<>();
Expand Down Expand Up @@ -564,7 +570,7 @@ public DistributionStatisticConfig configure(Meter.Id id, DistributionStatisticC
}

private void createVertxInstancesMetric() {
Gauge.builder("uid2_vertx_service_instances", () -> config.getInteger("service_instances"))
Gauge.builder("uid2_vertx_service_instances", () -> requestedServiceInstances)
.description("gauge for number of vertx service instances requested")
.register(Metrics.globalRegistry);
}
Expand Down
Loading