Skip to content

feat: Containerfile to create image from current source#601

Closed
Blaimi wants to merge 1 commit intoIBM:mainfrom
Blaimi:containerfile
Closed

feat: Containerfile to create image from current source#601
Blaimi wants to merge 1 commit intoIBM:mainfrom
Blaimi:containerfile

Conversation

@Blaimi
Copy link
Copy Markdown
Contributor

@Blaimi Blaimi commented Jun 9, 2023

PR summary

This PR adds a Containerfile to the repository and documentation on how to use it.

Documentation about container images have been removed in #599. Because of this, the image at jamescooke/openapi-validator got marked as deprecated.

PR Checklist

General checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
    • I made a github workflow which builds and uploads the image (build-image.yml), the build part could be adapted to test the build on every push/pr. Adapting the upload task would require some decisions about the image-target (dockerhub, quay, …) and how to handle tags and autobuilds.
  • Docs have been added / updated (for bug fixes / features)
  • Dependencies have been updated as needed
  • .secrets.baseline updated as needed?

Signed-off-by: Matthias Blümel <blaimi@blaimi.de>
@JohnStarich
Copy link
Copy Markdown
Member

@dpopp07 Thoughts on closing this one as complete since it was merged as part of #620?

@dpopp07
Copy link
Copy Markdown
Contributor

dpopp07 commented Aug 17, 2023

@JohnStarich good call

@Blaimi thanks for your effort on this!

@dpopp07 dpopp07 closed this Aug 17, 2023
@Blaimi Blaimi deleted the containerfile branch August 17, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants