Build and publish container images for easy integration#620
Build and publish container images for easy integration#620
Conversation
Signed-off-by: Matthias Blümel <blaimi@blaimi.de>
c20131f to
599d7a4
Compare
|
Hey all! I think this is ready for review. Before we merge, we should set up some way to log in to the appropriate registry before the |
599d7a4 to
bb5afac
Compare
542c62c to
9db4ce2
Compare
dpopp07
left a comment
There was a problem hiding this comment.
Looks great! I have a very small change request in the documentation but it's good otherwise. If you don't have anything else you want to do, once you've made that change, I'll approve and merge. Thanks for the PR!
|
|
||
| ### Docker container | ||
|
|
||
| Run the validator with the container image by mounting your `openapi.yaml` schema document. |
There was a problem hiding this comment.
Minor thing but this language is more consistent with the rest of the readme:
| Run the validator with the container image by mounting your `openapi.yaml` schema document. | |
| Run the validator with the container image by mounting your API definition. |
There was a problem hiding this comment.
Thanks! Updated, and should be all set. Only tricky part will be testing the deploy actually works.
a05d0a5 to
9f885c7
Compare
* Run test-docker in CI with a valid IBM ruleset extension * Add docs for container image use on README * Add deploy step to push images Signed-off-by: John Starich <johnstarich@johnstarich.com>
9f885c7 to
a5dcbf6
Compare
dpopp07
left a comment
There was a problem hiding this comment.
Looks good! Thanks for your work on this
# @ibm-cloud/openapi-ruleset [1.6.0](https://github.com/IBM/openapi-validator/compare/@ibm-cloud/openapi-ruleset@1.5.0...@ibm-cloud/openapi-ruleset@1.6.0) (2023-08-17) ### Features * build and publish container images for easy integration ([#620](#620)) ([062b462](062b462))
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |

PR summary
Builds and publishes container images in CI. PR builds ensure the image continues working
for a simple case, and
main/tagged builds publish new images.Thoughts on where these images should be pushed?
I selectedibmcom/...since it looks like there's already images out there for IBM. The GitHub registry might also be worth considering.Going with
ibmdevxsdksince we have access to that one.I thought the Containerfile idea Matthias introduced was pretty cool, but I don't think that has caught on as a standard yet and I don't want to confuse folks new to it. I changed it to Dockerfile for that reason.
PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements:
Checklist for adding a new validation rule:
N/A