Skip to content

feat: add speed gesture when fullscreen - #59

Merged
InfinityLoop1308 merged 3 commits into
InfinityLoop1308:devfrom
2gr:fullscreen-speed-controls
Jul 27, 2026
Merged

feat: add speed gesture when fullscreen#59
InfinityLoop1308 merged 3 commits into
InfinityLoop1308:devfrom
2gr:fullscreen-speed-controls

Conversation

@2gr

@2gr 2gr commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Hey, I implemented playback speed controls when in fullscreen (with some help from Claude) (ref. issue: InfinityLoop1308/PipePipe#825)

  • When enabled, swiping up or down in the middle of the screen controls the playback speed
  • To avoid issues w/ swiping to enter/exit fullscreen, the "Swipe to control playback speed" disables the "Fullscreen gesture control" option and vice-versa
  • When "Fullscreen gesture control" was off, there was a flicker when swiping on non-fullscreen video. The change on BasePlayerGestureListener.kt ensures that the flicker won't happen.
  • I arbitrarily set a min speed of 0.1 and a max of 4

If you require any changes at all let me know :)

EDIT: Forgot to include, but I did test the change on my own device

@InfinityLoop1308

Copy link
Copy Markdown
Owner

Thanks for working on this. The flicker in the non-fullscreen player is a separate known issue and does not need to be fixed in this PR, so I added a follow-up commit reverting the change to BasePlayerGestureListener.kt. I also updated the setting wording and added the corresponding localized strings.

@klaviartur

Copy link
Copy Markdown

Hey, I was planning on reimplementing this in PipePipe as I did in tubular, but I ran into IDE Problems and couldn't even start looking into the details yet. I'm glad and thankful, you did it and we all can use it pretty soon.
Still, whenever I find the time to sort out the infrastructure problems, I would like to give it a go and put this into a larger gesture concept that will allow for both controlling full screen and tempo with gestures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants